Document why configure.sh apply suppresses write stdout - #405
Merged
Conversation
Downstream carry reviews (PhotoCleaner#16) flag the stdout redirect on the apply writes as contradicting the AGENTS.md never-suppress-write-output rule. The suppression is stdout-only and safe by construction: gh errors go to stderr (never suppressed), set -Eeuo pipefail aborts on any non-zero exit, and configure.sh check verifies the applied end state independently. The AGENTS rule governs ad-hoc agent commands whose only verification is reading the response, which this fail-loud script is not. Say so in the canonical, at the top of cmd_apply, so every downstream copy carries the rationale and the flag stops recurring per carry PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explanatory comment in repo-config/configure.sh to justify why cmd_apply suppresses stdout for gh api write calls, aiming to prevent repeated downstream carry review findings about “never suppress write output”.
Changes:
- Add a multi-line comment above
cmd_apply’s write operations explaining stdout suppression rationale. - Document the intended “fail loud” behavior (stderr visibility, non-zero exits) and the role of
configure.sh checkas independent verification.
Uh oh!
There was an error while loading. Please reload this page.
…e citation Two lines carrying the safety reasoning (stdout-only, stderr untouched, fail-loud, check verifies the end state), no governance citation, per the comment conventions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream carry reviews (ptr727/PhotoCleaner#16 review thread) flag the stdout redirect on
cmd_apply's write calls as contradicting the AGENTS.md never-suppress-write-output rule. The suppression is stdout-only and safe by construction: gh errors go to stderr (never suppressed),set -Eeuo pipefailaborts on any non-zero exit, andconfigure.sh checkverifies the applied end state independently — the AGENTS rule governs ad-hoc agent commands whose only verification is reading the response.The canonical now says so at the top of
cmd_apply, so every downstream copy carries the rationale and the flag stops recurring on every carry PR.shellcheck clean, LF preserved. The verbatim canonical advances one revision (fleet copies become stale-by-one, tracked as usual by the burn-down).
🤖 Generated with Claude Code