Conversation
…audit checks (#404) CODESTYLE gains Central Build and Package Configuration (Directory.Build.props + Directory.Packages.props) with a matching csharp audit check; AGENTS.md Verification Discipline gains the never-edit-an-active-code-workspace rule; the audit gains three checks from maintainer ideas - cspell workspace duplication, HISTORY-mirrors-README opening, and About-description-mirrors-intro-line (link-free). All selftest-covered and live-verified.
Two-line rationale in the canonical at the top of cmd_apply (stdout-only, stderr untouched, fail-loud, check verifies the end state), so downstream carry reviews stop re-flagging the suppression.
Six downstream feedback items from the PhotoCleaner governance carry: MD033 text corrected, xUnit dynamic-skip carve-out adopted, canonical JSON reindented to 4-space, the ancestry-vs-content corrections (report, driftNote, template), codecov claims both stores (Dependabot-triggered runs read the Dependabot store), and the copilot-instructions manifest entry gains sections incl. the review runbook.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotion PR that syncs main with the current develop governance/audit canonicals, incorporating recent adoption-feedback updates (CODESTYLE, audit checks, repo-config hygiene, and report/registry corrections).
Changes:
- Extend the audit to validate README/HISTORY opening parity, README intro vs GitHub About description, and prevent duplicated CSpell word lists in workspace files.
- Update governance docs and spec baselines (central MSBuild config guidance, markdownlint MD033 policy, xUnit dynamic-skip carve-out, Copilot instructions required sections).
- Normalize canonicals and clean up drift documentation (JSON reindent, develop-vs-main “commit count” drift wording, registry drift note removal).
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
version.json | Reindent JSON to the 4-space canonical style (no behavioral change). |
spec/secrets.json | Require CODECOV_TOKEN in both secret stores and document the rationale. |
spec/readme-structure.md | Clarify README intro constraints and define HISTORY.md mirroring expectations. |
spec/project-types.json | Add a C# “central build/package config” expectation to the C# type checks. |
spec/files.json | Require specific headings in .github/copilot-instructions.md via sections. |
spec/audit.py | Add new audit checks for README/HISTORY mirroring, About-description mirroring, and workspace CSpell duplication. |
reports/photocleaner/audit.md | Reframe develop/main “behind” as benign for merge-commit promotions (ancestry vs content). |
reports/_template.md | Update the template guidance to classify develop/main drift by content, not commit count. |
repo-config/settings.json | Reindent JSON to the 4-space canonical style. |
repo-config/configure.sh | Add rationale comment explaining stdout suppression for write calls. |
registry/repos.json | Remove the incorrect PhotoCleaner drift note about forward-syncing promotion merge commits. |
CODESTYLE.md | Update markdownlint MD033 guidance; add central MSBuild config guidance; clarify xUnit dynamic-skip exception. |
AGENTS.md | Add “never edit an active .code-workspace file” to Verification Discipline. |
Comment on lines
+38
to
+39
| "stores": ["actions", "dependabot"], | ||
| "note": "A csharp or python repo lists CODECOV_TOKEN in its registry requiredSecrets (unlike the implicit baseline secrets). Both stores: a workflow run triggered by a Dependabot PR reads the Dependabot secrets store, so without that copy the coverage upload silently skips on every bot PR. Coverage upload is report-only by default (fail_ci_if_error: false, so a Codecov hiccup never fails the gate). A repo may enforce a stricter threshold (e.g. 99%+) on top of that default." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the develop line to main. Merge-commit promotion (not squash);
developis the head and is never deleted.Included (3 commits)
Directory.Build.props+Directory.Packages.props) with thecsharp.centralconfig.propsaudit check; the absolute never-edit-an-active-.code-workspacerule in the verbatim-carried Verification Discipline; three new audit checks (cspell workspace duplication, HISTORY-mirrors-README, About-description-mirrors-intro).configure.shstdout-suppression rationale in the canonical (kills the recurring downstream review flag).Why now
The PhotoCleaner round-2 convergence vendors canonicals from
main— this makes them current (CODESTYLE, Verification Discipline, configure.sh, version.json, settings.json, plus the new checks).Verification
validate.pygreen,--selftestpasses, trial merge conflict-free (0 markers). Human merge — no release fires.🤖 Generated with Claude Code