Skip to content

Apply the PhotoCleaner round-1 feedback batch - #406

Merged
ptr727 merged 2 commits into
developfrom
adoption-feedback-batch
Jul 23, 2026
Merged

Apply the PhotoCleaner round-1 feedback batch#406
ptr727 merged 2 commits into
developfrom
adoption-feedback-batch

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Six of the seven downstream feedback items from the PhotoCleaner governance carry (ptr727/PhotoCleaner#14 feedback comment); item 3 shipped separately as #405.

  1. MD033 — CODESTYLE no longer lists it among the deliberately disabled rules; the canonical config enables it (inline HTML for comments only), and the text now says so.
  2. xUnit dynamic-skip carve-out — adopting the downstream wording: Assert.Skip/Assert.SkipWhen is control flow, not an assertion, and stays native.
  3. Canonical JSON indentationversion.json (tabs) and repo-config/settings.json (2-space) reindented to the fleet's 4-space convention. CRLF preserved, content unchanged.
  4. Ancestry vs content — the audit's branch check was already content-based (and correctly silent on PhotoCleaner); the hand-written artifacts were wrong. The PhotoCleaner report's Develop Drift now classifies the promotion ancestry gap as benign, the erroneous registry driftNote is gone (it also tripped the pending-marker freshness check), and reports/_template.md now instructs classifying by content, not commit count.
  5. Codecov storesspec/secrets.json claims both stores with the rationale: Dependabot-triggered runs read the Dependabot store, so without that copy coverage upload silently skips on every bot PR.
  6. Runbook mechanized — the copilot-instructions manifest entry gains sections (incl. "GitHub Copilot Review Runbook"); live-verified — PhotoCleaner now surfaces both missing headings.

Verification

validate.py green, --selftest passes, all JSON valid, markdownlint clean, CRLF preserved. Live: PhotoCleaner post-round-1 audit shows the two new section DRIFTs and no branch/driftNote noise (13 findings, down from 15 after its carry landed).

🤖 Generated with Claude Code

Downstream feedback from the PhotoCleaner governance carry (PhotoCleaner#14), item 3 already
shipped separately (#405):
1. CODESTYLE no longer lists MD033 among the deliberately disabled markdownlint rules - the
canonical config enables it (inline HTML for comments only), and the text now says so.
2. The xUnit assert ban gains the dynamic-skip carve-out, adopting the downstream wording:
dynamic test skipping (Assert.Skip, Assert.SkipWhen) is control flow, not an assertion,
and stays native - AwesomeAssertions has no equivalent.
4. version.json (tabs) and repo-config/settings.json (2-space) reindented to the fleet's own
4-space JSON convention. CRLF preserved, content unchanged.
5. The ancestry-vs-content correction: the audit's branch check was already content-based and
correctly silent on PhotoCleaner, but the hand-written artifacts prescribed a no-op
cherry-pick - the PhotoCleaner report's Develop Drift now classifies the promotion
ancestry gap as benign, the wrong registry driftNote is removed (it also tripped the
pending-marker freshness check), and the report template now says classify by content,
not commit count.
6. spec/secrets.json codecov claims both stores with the rationale: a workflow run triggered
by a Dependabot PR reads the Dependabot secrets store, so without that copy coverage
upload silently skips on every bot PR.
7. The copilot-instructions manifest entry gains sections (Commit Messages and Pull Request
Titles, GitHub Copilot Review Runbook), so a downstream copy without the runbook flags
mechanically - verified live, PhotoCleaner now surfaces both missing headings.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 23, 2026 16:24

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies a batch of downstream governance feedback items from PhotoCleaner by tightening spec/audit semantics, updating documentation to match canonical lint/testing intent, and normalizing a couple of JSON files to the fleet indentation convention.

Changes:

  • Normalize JSON indentation in version.json and repo-config/settings.json to the fleet 4-space convention (content unchanged).
  • Clarify develop-vs-main drift reporting to classify by tree/content (benign promotion ancestry gaps) and remove the corresponding incorrect registry drift note.
  • Update governance specs and docs: add required sections coverage for .github/copilot-instructions.md, correct MD033 guidance, add xUnit dynamic-skip carve-out, and require Codecov token in both Actions + Dependabot secret stores.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
version.jsonReindent to 4 spaces for canonical JSON formatting.
spec/secrets.jsonRequire Codecov token in both secret stores and explain why.
spec/files.jsonAdd sections coverage for .github/copilot-instructions.md in the baseline manifest.
reports/photocleaner/audit.mdReclassify develop/main commit-count divergence as benign when trees match (promotion merge ancestry).
reports/_template.mdUpdate template guidance to classify drift by content, not commit count.
repo-config/settings.jsonReindent to 4 spaces for canonical JSON formatting.
registry/repos.jsonRemove erroneous drift note about develop trailing main by promotion merge commits.
CODESTYLE.mdUpdate markdownlint MD033 guidance and document xUnit dynamic skip carve-out.

Comment threadspec/secrets.json Outdated
Comment threadCODESTYLE.md Outdated
The xUnit framework bullet and the codecov note both carried a pre-existing semicolon in the
lines this batch touched. Recast as sentences, and the framework bullet gains its terminating
period.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 23, 2026 16:27

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit d8bc0d7 into developJul 23, 2026
7 checks passed
@ptr727
ptr727 deleted the adoption-feedback-batch branch July 23, 2026 16:32
ptr727 added a commit that referenced this pull request Jul 23, 2026
…onical fixes (#407)
Merge-commit promotion of #404-#406: central MSBuild config + workspace rule + three repo-hygiene audit checks, the configure.sh stdout-suppression rationale, and the PhotoCleaner round-1 feedback batch. Human merge, no release fires. Makes main's canonicals current for the PhotoCleaner round-2 convergence.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727