Apply the PhotoCleaner round-1 feedback batch - #406
Merged
Conversation
Downstream feedback from the PhotoCleaner governance carry (PhotoCleaner#14), item 3 already shipped separately (#405): 1. CODESTYLE no longer lists MD033 among the deliberately disabled markdownlint rules - the canonical config enables it (inline HTML for comments only), and the text now says so. 2. The xUnit assert ban gains the dynamic-skip carve-out, adopting the downstream wording: dynamic test skipping (Assert.Skip, Assert.SkipWhen) is control flow, not an assertion, and stays native - AwesomeAssertions has no equivalent. 4. version.json (tabs) and repo-config/settings.json (2-space) reindented to the fleet's own 4-space JSON convention. CRLF preserved, content unchanged. 5. The ancestry-vs-content correction: the audit's branch check was already content-based and correctly silent on PhotoCleaner, but the hand-written artifacts prescribed a no-op cherry-pick - the PhotoCleaner report's Develop Drift now classifies the promotion ancestry gap as benign, the wrong registry driftNote is removed (it also tripped the pending-marker freshness check), and the report template now says classify by content, not commit count. 6. spec/secrets.json codecov claims both stores with the rationale: a workflow run triggered by a Dependabot PR reads the Dependabot secrets store, so without that copy coverage upload silently skips on every bot PR. 7. The copilot-instructions manifest entry gains sections (Commit Messages and Pull Request Titles, GitHub Copilot Review Runbook), so a downstream copy without the runbook flags mechanically - verified live, PhotoCleaner now surfaces both missing headings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Applies a batch of downstream governance feedback items from PhotoCleaner by tightening spec/audit semantics, updating documentation to match canonical lint/testing intent, and normalizing a couple of JSON files to the fleet indentation convention.
Changes:
- Normalize JSON indentation in
version.jsonandrepo-config/settings.jsonto the fleet 4-space convention (content unchanged). - Clarify develop-vs-main drift reporting to classify by tree/content (benign promotion ancestry gaps) and remove the corresponding incorrect registry drift note.
- Update governance specs and docs: add required
sectionscoverage for.github/copilot-instructions.md, correct MD033 guidance, add xUnit dynamic-skip carve-out, and require Codecov token in both Actions + Dependabot secret stores.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Reindent to 4 spaces for canonical JSON formatting. |
| spec/secrets.json | Require Codecov token in both secret stores and explain why. |
| spec/files.json | Add sections coverage for .github/copilot-instructions.md in the baseline manifest. |
| reports/photocleaner/audit.md | Reclassify develop/main commit-count divergence as benign when trees match (promotion merge ancestry). |
| reports/_template.md | Update template guidance to classify drift by content, not commit count. |
| repo-config/settings.json | Reindent to 4 spaces for canonical JSON formatting. |
| registry/repos.json | Remove erroneous drift note about develop trailing main by promotion merge commits. |
| CODESTYLE.md | Update markdownlint MD033 guidance and document xUnit dynamic skip carve-out. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The xUnit framework bullet and the codecov note both carried a pre-existing semicolon in the lines this batch touched. Recast as sentences, and the framework bullet gains its terminating period. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
ptr727 added a commit
that referenced
this pull request
Jul 23, 2026
…onical fixes (#407) Merge-commit promotion of #404-#406: central MSBuild config + workspace rule + three repo-hygiene audit checks, the configure.sh stdout-suppression rationale, and the PhotoCleaner round-1 feedback batch. Human merge, no release fires. Makes main's canonicals current for the PhotoCleaner round-2 convergence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six of the seven downstream feedback items from the PhotoCleaner governance carry (ptr727/PhotoCleaner#14 feedback comment); item 3 shipped separately as #405.
Assert.Skip/Assert.SkipWhenis control flow, not an assertion, and stays native.version.json(tabs) andrepo-config/settings.json(2-space) reindented to the fleet's 4-space convention. CRLF preserved, content unchanged.reports/_template.mdnow instructs classifying by content, not commit count.spec/secrets.jsonclaims both stores with the rationale: Dependabot-triggered runs read the Dependabot store, so without that copy coverage upload silently skips on every bot PR.sections(incl. "GitHub Copilot Review Runbook"); live-verified — PhotoCleaner now surfaces both missing headings.Verification
validate.pygreen,--selftestpasses, all JSON valid, markdownlint clean, CRLF preserved. Live: PhotoCleaner post-round-1 audit shows the two new section DRIFTs and no branch/driftNote noise (13 findings, down from 15 after its carry landed).🤖 Generated with Claude Code