gh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` by brijkapadia · Pull Request #146006 · python/cpython

brijkapadia · 2026-03-16T02:21:14Z

Changes

Removed DELETE_NAME
When STORE_NAME receives a NULL value, it corresponds with deletion

Issue: Remove DELETE_NAME instruction #145854

📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/

Changes - Removed `DELETE_NAME` - When `STORE_NAME` receives a `NULL` value, it corresponds with deletion

brijkapadia · 2026-03-16T10:40:04Z

I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated.

markshannon · 2026-03-16T13:52:19Z

This will need a magic number bump (as do all changes that add or remove opcodes)

markshannon

Looks good. Thanks for doing this.

brijkapadia · 2026-03-27T20:28:19Z

@markshannon A gentle reminder about this PR.

kumaraditya303 · 2026-04-16T05:55:01Z

A gentle reminder about this PR.

There are merge conflicts.

python-cla-bot · 2026-04-17T02:04:47Z

All commit authors signed the Contributor License Agreement.

markshannon · 2026-05-01T10:18:37Z

Sorry for leaving this sitting for so long.

I notice that _STORE_NAME is no longer suitable for jitting and is also quite large, so would bloat the stencils if it were.
Can you factor out the body of it into a _PyEval_StoreName() helper function?

read-the-docs-community · 2026-05-29T16:15:59Z

Documentation build overview

📚 cpython-previews | 🛠️ Build #33374710 | 📁 Comparing 87c2898 against main (2a07ff9)

🔍 Preview build

254 files changed · + 6 added · ± 247 modified · - 1 deleted

+Added

±Modified

-Deleted

library/asyncio-policy.html

brijkapadia · 2026-06-26T16:07:22Z

@markshannon A reminder about this PR, whenever you get a chance

markshannon

Looks good. Thanks for doing this.

I mistake in the magic number comment and needs merge conflicts fixing.
Otherwise, good to merge.

bedevere-app · 2026-06-30T13:22:41Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Mark Shannon <Mark.Shannon@arm.com>

brijkapadia · 2026-06-30T13:44:30Z

I have made the requested changes; please review again

bedevere-app · 2026-06-30T13:44:37Z

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

markshannon

Thanks

* main: (266 commits) pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952) pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729) pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713) pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716) pythongh-152433: Windows: enable mmapmodule for UWP (python#152473) pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383) pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693) pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705) pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314) pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006) pythongh-152680: Detect container/VM in test.pythoninfo (python#152668) pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684) pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683) pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547) pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478) pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642) pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653) pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309) pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382) Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311) ...

pythongh-145854: ReplaceDELETE_NAMEwithPUSH_NULL; STORE_NAME
1f97a49
Changes - Removed `DELETE_NAME` - When `STORE_NAME` receives a `NULL` value, it corresponds with deletion

brijkapadia requested review from ericsnowcurrently, iritkatriel and markshannon as code owners March 16, 2026 02:21

bedevere-appBot mentioned this pull request Mar 16, 2026
Remove DELETE_NAME instruction #145854
Closed

bedevere-appBot added the awaiting review label Mar 16, 2026

📜🤖 Added by blurb_it.
ed1b971

brijkapadia mentioned this pull request Mar 16, 2026
gh-145749: Optimize named exception blocks #145983
Open

brijkapadia marked this pull request as draft March 16, 2026 02:31

bedevere-appBot removed the awaiting review label Mar 16, 2026

brijkapadia marked this pull request as ready for review March 16, 2026 10:39

bedevere-appBot added the awaiting review label Mar 16, 2026

picnixz reviewed Mar 16, 2026
View reviewed changes

Comment threadPython/bytecodes.c Outdated

picnixz reviewed Mar 16, 2026
View reviewed changes

Comment threadPython/bytecodes.c Outdated

Updated STORE_FAST; Changed magic number; Added test
93d91b8

brijkapadia mentioned this pull request Mar 17, 2026
Remove DELETE_GLOBAL bytecode instruction #145857
Closed

markshannon approved these changes Mar 17, 2026
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels Mar 17, 2026

brijkapadia added 4 commits March 19, 2026 19:27

Merge branch 'main' into delete-name
68a9599

Update generated files and magic number
68383f5

Merge branch 'main' into delete-name
6adc1d0

Update generated files/magic number
0bbfa52

Merge branch 'main' into delete-name
6dc57ee

Update generated files; Update magic number
da4dc56

Merge branch 'main' into delete-name
2e9eecd

brijkapadia added 2 commits May 29, 2026 12:17

Fix merge errors
a72a434

create _PyEval_StoreName
2340680

brijkapadia requested a review from markshannon May 29, 2026 16:52

brijkapadia added 4 commits May 31, 2026 14:27

fix test
cb7ad39

Merge remote-tracking branch 'upstream/main' into delete-name
9c1f73c

update helper function
6be315b

update generated files
22867fc

markshannon requested changes Jun 30, 2026
View reviewed changes

Comment threadInclude/internal/pycore_magic_number.h Outdated

bedevere-appBot added awaiting changes and removed awaiting merge labels Jun 30, 2026

brijkapadiaand others added 2 commits June 30, 2026 09:35

Update Include/internal/pycore_magic_number.h
45ce2e5
Co-authored-by: Mark Shannon <Mark.Shannon@arm.com>

Merge remote-tracking branch 'upstream/main' into delete-name
87c2898

bedevere-appBot added awaiting change review and removed awaiting changes labels Jun 30, 2026

bedevere-appBot requested a review from markshannon June 30, 2026 13:44

markshannon approved these changes Jun 30, 2026
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting change review labels Jun 30, 2026

markshannon merged commit c393ab6 into python:mainJun 30, 2026
83 of 86 checks passed

bedevere-appBot removed the awaiting merge label Jun 30, 2026

brijkapadia deleted the delete-name branch June 30, 2026 16:33

markshannon mentioned this pull request Jun 30, 2026
gh-145855: Remove the DELETE_ATTR bytecode #146216
Merged

Uh oh!

Uh oh!

Conversation

brijkapadia commented Mar 16, 2026• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brijkapadia commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

markshannon commented Mar 16, 2026

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

brijkapadia commented Mar 27, 2026

Uh oh!

kumaraditya303 commented Apr 16, 2026

Uh oh!

python-cla-botBot commented Apr 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markshannon commented May 1, 2026

Uh oh!

read-the-docs-communityBot commented May 29, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

brijkapadia commented Jun 26, 2026

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-appBot commented Jun 30, 2026

Uh oh!

brijkapadia commented Jun 30, 2026

Uh oh!

bedevere-appBot commented Jun 30, 2026

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

brijkapadia commented Mar 16, 2026•
edited by github-actions Bot
Loading

python-cla-botBot commented Apr 17, 2026•
edited
Loading

read-the-docs-communityBot commented May 29, 2026•
edited
Loading