Don't require _testcapi and _testinternalcapi for test_monitoring.py

[ShaharNaveh]

same as #152171 and #152185

[StanFromIreland]

Do you know if there any more tests with the same issues (I'm not familiar with RustPython, so I don't know where to even try finding a list)? I'd rather get them all done in one go.

[StanFromIreland]

This'll be executed at import time, so it will skip test_monitoring defeating the whole point of this PR. You can move it to a setUpClass.

[ShaharNaveh]

Do you know if there any more tests with the same issues (I'm not familiar with RustPython, so I don't know where to even try finding a list)? I'd rather get them all done in one go.

We are copying the tests from CPython directly into Lib/test, this structure might look familiar:)

---

Anyway, I've gathered a list using a small script:

• Lib/test/audit-tests.py
• Lib/test/test_fileutils.py
• Lib/test/test_optimizer.py
• Lib/test/test_monitoring.py
• Lib/test/test_type_cache.py
• Lib/test/test_thread_local_bytecode.py
• Lib/test/test_c_stack_unwind.py
• Lib/test/test_free_threading/test_dict_watcher.py
• Lib/test/test_gdb/test_jit.py

I've looked at each of those tests, all but test_monitoring.py requires either _testcapi or _testinternalcapi it seems. so this should be the last PR regarding this (hopefully).

Script used for findings

importastimportpathlibROOT=pathlib.Path(__file__).parentTEST_DIR=ROOT/"Lib/test"classVisitor(ast.NodeVisitor):
def__init__(self):
self.found=Falsedefvisit_Call(self, node):
func=node.funcifnotisinstance(func, ast.Attribute):
returniffunc.attr!="import_module":
returnargs=node.argsiflen(args) !=1:
returnarg=args[0]
ifnotisinstance(arg, ast.Constant):
returnvalue=arg.valueself.found=valuein ("_testcapi", "_testinternalcapi")
defvisit_ClassDef(self, node):
forbnodeinnode.body:
ifisinstance(bnode, ast.Assign):
returnself.generic_visit(bnode)
defvisit_FuncionDef(self, node):
returndefvisit_AsyncFunctionDef(self, node):
returnbad=set()
forchildinTEST_DIR.glob("**/*.py"):
if"test_capi"inchild.parts:
continuerchild=child.relative_to(ROOT)
try:
source=child.read_text(encoding="utf-8")
mod=ast.parse(source)
except:
bad.add(rchild)
continuevisitor=Visitor()
visitor.visit(mod)
ifvisitor.found:
print(rchild)
# print("\ncould not parse:\n" + "\n".join(map(str, bad)))

[StanFromIreland]

Interestingly this uncovers UB in INSTRUMENTED_JUMP, I have a patch at #152376 to fix it and allow merging. I thought it would be accidental but after two re-runs it still hits it.

[ShaharNaveh]

Interestingly this uncovers UB in INSTRUMENTED_JUMP, I have a patch at #152376 to fix it and allow merging. I thought it would be accidental but after two re-runs it still hits it.

I see that it just crashes without any information:/
Weird, I wonder if the test isn't isolated. maybe it somehow relies on importing _testcapi once at the top?

Anway, I've subscribed to #152376 so I'll update the PR once it's merged. puting on draft for now

[StanFromIreland]

I see that it just crashes without any information:/

See the "Display logs" step, which has the UBSan output.

[ShaharNaveh]

Seems like #152376 fixed it. tysm for looking into it!

[StanFromIreland]

LGTM, thanks.

[miss-islington-app]

Thanks @ShaharNaveh for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

[bedevere-app]

GH-152660 is a backport of this pull request to the 3.15 branch.

[bedevere-app]

GH-152661 is a backport of this pull request to the 3.14 branch.

[miss-islington-app]

Thanks @ShaharNaveh for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @ShaharNaveh and @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 189ab8388762c8102b2d72ad3a1a921f7f2aef10 3.13

[StanFromIreland]

Skipping backport to 3.13 here.