Skip to content

gh-151029: Fix test_remote_exec_deleted_static_executable on static installed builds - #152653

Merged
encukou merged 1 commit into
python:mainfrom
StanFromIreland:test_remote_exec_deleted_static_executable
Jun 30, 2026
Merged

gh-151029: Fix test_remote_exec_deleted_static_executable on static installed builds#152653
encukou merged 1 commit into
python:mainfrom
StanFromIreland:test_remote_exec_deleted_static_executable

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

test_remote_exec_deleted_static_executable (from gh-151029) rebuilds a fake build-tree and symlinks the stdlib via srcdir/Lib, but on an installed Python sysconfig's srcdir points at the config-* directory (which has no Lib/). The copied interpreter then can't find the stdlib, so it dies at startup before connecting (server_socket.accept() hangs until it raises TimeoutError). Failed run, for example.

@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting core review labels Jun 30, 2026
@StanFromIrelandStanFromIreland changed the title Fix test_remote_exec_deleted_static_executable on static installed …gh-151029: Fix test_remote_exec_deleted_static_executable on static installed buildsJun 30, 2026
@bedevere-appbedevere-appBot mentioned this pull request Jun 30, 2026
Closed
@StanFromIreland

StanFromIreland commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

!buildbot installed|riscv64

(Note: The RISC-V buildbot runs a static installed build, but it just doesn’t have it in the name)

@bedevere-bot

bedevere-bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit a2bf789 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152653%2Fmerge

The command will test the builders whose names match following regular expression: installed|riscv64

The builders matched are:

  • aarch64 CentOS10 Clang Installed PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Clang Installed PR
  • riscv64 Ubuntu23 PR
  • s390x Fedora Stable Clang Installed PR
  • x86 Debian Installed with X PR
  • aarch64 Fedora Stable Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Rawhide Clang Installed PR

encukou
encukou reviewed Jun 30, 2026
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Out-of-tree builds strike again.
Thanks for looking into this!

+1 if buildbots are green. (I don't know if this is the best way to do things, but it looks OK to me, and unbreaking buildbots is an improvement.)

@StanFromIreland

StanFromIreland commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks for the review. I did consider just skipping it in this case, but the Lib/os.py workaround isn't too messy.

Fix confirmed, e.g. x86 Debian Installed with X 3.x which has been consistently failing on the test now passes. I'll wait till they all run.

This was referenced Jun 30, 2026
Closed
Open
@encukou
encukou merged commit 03efeef into python:mainJun 30, 2026
61 checks passed
@encukouencukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 30, 2026
@miss-islington-app

miss-islington-appBot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 30, 2026

Copy link
Copy Markdown

GH-152669 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 30, 2026
@bedevere-app

bedevere-appBot commented Jun 30, 2026

Copy link
Copy Markdown

GH-152670 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 30, 2026
@StanFromIreland
StanFromIreland deleted the test_remote_exec_deleted_static_executable branch June 30, 2026 10:48
StanFromIreland added a commit that referenced this pull request Jun 30, 2026
@miss-islington@StanFromIreland
[3.15]gh-151029: Fixtest_remote_exec_deleted_static_executableon…
eebdbfd
… static installed builds (GH-152653) (#152670)
(cherry picked from commit 03efeef)
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 30, 2026
@miss-islington@StanFromIreland
[3.14]gh-151029: Fixtest_remote_exec_deleted_static_executableon…
940be2e
… static installed builds (GH-152653) (#152669)
(cherry picked from commit 03efeef)
Co-authored-by: Stan Ulbrych <stan@python.org>
maurycy added a commit to maurycy/cpython that referenced this pull request Jul 1, 2026
@maurycy
Merge branch 'main' into maurycy/bye-abba
da7d768
* main: (266 commits)
pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952)
pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729)
pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713)
pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716)
pythongh-152433: Windows: enable mmapmodule for UWP (python#152473)
pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383)
pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693)
pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705)
pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314)
pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006)
pythongh-152680: Detect container/VM in test.pythoninfo (python#152668)
pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684)
pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683)
pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547)
pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478)
pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642)
pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653)
pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309)
pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382)
Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments
@ambvambvAwaiting requested review from ambv
@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@bedevere-bot@encukou