Integrate torchgen exception boundary with ExecuTorch - #7546

Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom
gh/swolchok/124/head
Feb 7, 2025
Merged

Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom
gh/swolchok/124/head

Conversation

@swolchok

@swolchokswolchok commented Jan 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Jan 7, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6339d09 with merge base 832f855 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2025
@swolchokswolchok mentioned this pull request Jan 7, 2025
Merged
@facebook-github-bot

facebook-github-bot commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchokswolchok mentioned this pull request Jan 6, 2025
Merged
@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot

facebook-github-bot commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchokswolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 7, 2025
@swolchok
swolchok marked this pull request as draft January 7, 2025 22:28
@swolchok

swolchok commented Jan 7, 2025

Copy link
Copy Markdown
ContributorAuthor

converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed

huydhn
huydhn reviewed Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake Outdated
huydhn
huydhn reviewed Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake Outdated
)
)
if(GEN_ADD_EXCEPTION_BOUNDARY)
set(_gen_command "${_gen_command} --add-exception-boundary")

@huydhnhuydhnJan 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary

The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change
set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)

@swolchokswolchokJan 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.

@swolchokswolchokJan 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186

@swolchokswolchokJan 9, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:

however, we do have mac successes. looking into the common thread for these failures now.

@swolchokswolchokJan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?

test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.

@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

swolchok added a commit that referenced this pull request Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot

facebook-github-bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

swolchok added a commit that referenced this pull request Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit that referenced this pull request Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok mentioned this pull request Jan 9, 2025
Merged
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok mentioned this pull request Jan 9, 2025
Closed
@facebook-github-bot

facebook-github-bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

swolchok added a commit that referenced this pull request Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit that referenced this pull request Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchokswolchok changed the title Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchok

swolchok commented Jan 31, 2025

Copy link
Copy Markdown
ContributorAuthor

looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main

kirklandsign pushed a commit that referenced this pull request Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin

mergennachin commented Feb 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)

Somewhat complementary but related

Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@swolchok
swolchok marked this pull request as ready for review February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D67904052

@facebook-github-bot
facebook-github-bot merged commit 4653028 into gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot deleted the gh/swolchok/124/head branch February 7, 2025 23:03
@pytorchbotpytorchbot mentioned this pull request Feb 7, 2025
Merged
swolchok pushed a commit that referenced this pull request Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments
+1 more reviewer
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Integrate torchgen exception boundary with ExecuTorch - #7546
Merged
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Feb 7, 2025
Merged
Integrate torchgen exception boundary with ExecuTorch#7546
facebook-github-bot merged 25 commits into
gh/swolchok/124/basefrom 
gh/swolchok/124/head
Conversation
@swolchok
@swolchokswolchok
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok
Build optimized operators lib with -fexceptions
238d6f0
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Jan 7, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit 6339d09 with merge base 832f855 (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 7, 2025
@swolchokswolchok
mentioned this pull request
Jan 7, 2025
 Merged

@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
mentioned this pull request
Jan 6, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
eacf0db
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 7, 2025
@swolchok
Build optimized operators lib with -fexceptions
5714d2e
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260556841
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
added
the 
release notes: build
Changes related to build, including dependency upgrades, build flags, optimizations, etc.
label
Jan 7, 2025
@swolchok
swolchok
marked this pull request as draft
January 7, 2025 22:28
@swolchok
swolchok
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed
huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

huydhn
huydhn
reviewed
Jan 8, 2025
View reviewed changes
Comment threadbuild/Codegen.cmake
Outdated

 )
 )
 if(GEN_ADD_EXCEPTION_BOUNDARY)
 set(_gen_command "${_gen_command} --add-exception-boundary")
@huydhnhuydhnJan 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary
The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")
set(_gen_command "${_gen_command}" --add-exception-boundary)
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I thought I built this locally. Giving it a shot now.
@swolchokswolchokJan 8, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186
@swolchokswolchokJan 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn still seeing at least some wrong-torchgen-version failures:
however, we do have mac successes. looking into the common thread for these failures now.
@swolchokswolchokJan 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?
test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.
@swolchok
Update on "Build optimized operators lib with -fexceptions"
85f1f22
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 8, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 8, 2025
@swolchok
Build optimized operators lib with -fexceptions
99a8848
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260686358
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f375188
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
ea08f62
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260777714
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Build optimized operators lib with -fexceptions"
b405dbd
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
Build optimized operators lib with -fexceptions
b7a6973
Pull Request resolved: #7546
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
ghstack-source-id: 260814512
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
swolchok added a commit
that referenced
this pull request
Jan 9, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
16020a4
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Merged

@swolchok
Update on "Build optimized operators lib with -fexceptions"
b34b10d
It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Jan 9, 2025
 Closed

@facebook-github-bot
facebook-github-bot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
swolchok added a commit
that referenced
this pull request
Jan 28, 2025
@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation
7ce6615
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
manuelcandales pushed a commit
that referenced
this pull request
Jan 29, 2025
@pytorchbot@swolchok
use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
c54f4df
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@swolchok
Update on "Build optimized operators lib with -fexceptions"
f2fb0b1
It should be permissible for this library to use exceptions, since it is not required to support embedded systems.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchokswolchok
changed the title
Build optimized operators lib with -fexceptionsIntegrate torchgen exception boundary with ExecuTorchJan 30, 2025
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
de1cc23
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
3ffb5d2
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
Update on "Integrate torchgen exception boundary with ExecuTorch"
00f6b85
As of #7746, we build with exceptions by default, so we just need to use them.
TODO: presumably we need to manage rollout of the torchgen patch?
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
commented
Jan 31, 2025

Copy link


Copy Markdown

ContributorAuthor
looks like tests are good; the github export mechanism just doesn't seem to be basing the PRs off main
kirklandsign pushed a commit
that referenced
this pull request
Jan 31, 2025
@pytorchbot@swolchok
--use-pt-pinned-commit in one-off linux jobs
20f9f5f
* --use-pt-pinned-commit in one-off linux jobs
Pull Request resolved: #7922
This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport
Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)
* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)
Pull Request resolved: #7579
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport
Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
Co-authored-by: Scott Wolchok <swolchok@meta.com>
---------
Co-authored-by: Scott Wolchok <swolchok@meta.com>
@mergennachin
mergennachin
commented
Feb 4, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@swolchok - FYI, there's a PR here to improve torchgen package import (#6730), related original issue (#6689)
Somewhat complementary but related
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
aff01f5
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
59b5088
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@swolchok
swolchok
marked this pull request as ready for review
February 5, 2025 16:35
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
99b4a3d
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
078941b
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
Github Executorch
Update on "Integrate torchgen exception boundary with ExecuTorch"
6339d09
As of #7746, we build with exceptions by default, so we just need to use them.
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D67904052
@facebook-github-bot
facebook-github-bot
merged commit 4653028
into
gh/swolchok/124/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/124/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 11, 2025
@pytorchbotGithub Executorch
Integrate torchgen exception boundary with ExecuTorch (#8321)
d92a763
Pull Request resolved: #7546
As of #7746, we build with exceptions by default, so we just need to use them.
ghstack-source-id: 265190625
@exported-using-ghexport
Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@huydhnhuydhnhuydhn left review comments

+1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok@facebook-github-bot@mergennachin@huydhn@kimishpatel