Skip to content

Add extension/llm/custom_ops/spinquant/test to CMake - #8345

Merged
swolchok merged 20 commits into
mainfrom
gh/swolchok/242/head
Feb 26, 2025
Merged

Add extension/llm/custom_ops/spinquant/test to CMake#8345
swolchok merged 20 commits into
mainfrom
gh/swolchok/242/head

Conversation

@swolchok

@swolchokswolchok commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Need to run it to make sure build changes in this directory aren't breaking things.

Test Plan: added EXPECT_TRUE(false) to fast_hadamard_transform_test.cpp, saw failure in test/run_oss_cpp_tests.sh

@pytorch-bot

pytorch-botBot commented Feb 10, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8345

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b52f223 with merge base f3fc096 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

this isn't correct yet; test doesn't run when I run test/run_oss_cpp_tests.sh and I'm not sure why yet.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

temporarily adding --trace to the problem cmake command in build-llm-demo since I can't repro locally

@swolchok
swolchok requested a review from dbort as a code ownerFebruary 24, 2025 17:39
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Need to run it to make sure build changes in this directory aren't breaking things
ghstack-source-id: 765a3dc
ghstack-comment-id: 2648964965
Pull Request resolved: #8345
@swolchok

Copy link
Copy Markdown
ContributorAuthor

temporarily adding --trace to the problem cmake command in build-llm-demo since I can't repro locally

the correct cmake command was in extension/android_test/setup.sh, but I still can't figure out what's going on so now i'm just tracing all 4 cmake invocations

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Need to run it to make sure build changes in this directory aren't breaking things
ghstack-source-id: 331d7ab
ghstack-comment-id: 2648964965
Pull Request resolved: #8345
@swolchok

Copy link
Copy Markdown
ContributorAuthor

the inexplicable build of tests seems to be because including abseil-cpp's CMakeLists.txt sets BUILD_TESTING to ON by default because it does include(CTest). trying out find_package(GTest) in et_cxx_test to see if it fixes the issue

[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

this looks good, please review

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Base automatically changed from gh/swolchok/280/head to mainFebruary 26, 2025 20:11
@swolchok
swolchok merged commit 6410d47 into mainFeb 26, 2025
@swolchok
swolchok deleted the gh/swolchok/242/head branch February 26, 2025 20:11
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
Need to run it to make sure build changes in this directory aren't breaking things
ghstack-source-id: 747dbdb
ghstack-comment-id: 2648964965
Pull Request resolved: pytorch/executorch#8345
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@GregoryComer@facebook-github-bot