Skip to content

build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS - #8398

Merged
swolchok merged 97 commits into
mainfrom
gh/swolchok/254/head
Aug 15, 2025
Merged

build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS#8398
swolchok merged 97 commits into
mainfrom
gh/swolchok/254/head

Conversation

@swolchok

@swolchokswolchok commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268

@swolchok
Update
07adf1a
[ghstack-poisoned]
@swolchok
Update
bc3fd39
[ghstack-poisoned]
@swolchok
Update
00ce927
[ghstack-poisoned]
@swolchok
Update
6440d3d
[ghstack-poisoned]
@swolchok
Update
e62191a
[ghstack-poisoned]
@swolchok
Update
630bdd0
[ghstack-poisoned]
@swolchok
Update
098432f
[ghstack-poisoned]
@swolchok
Update
773ff37
[ghstack-poisoned]
@swolchok
Update
87513d8
[ghstack-poisoned]
@swolchok
Update
b61319b
[ghstack-poisoned]
@swolchok
Update
4265c31
[ghstack-poisoned]
@swolchok
Update
190bea8
[ghstack-poisoned]
@swolchok

swolchok commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@swolchokswolchok mentioned this pull request Feb 12, 2025
Merged
@pytorch-bot

pytorch-botBot commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8398

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 73 Pending

As of commit b219e9b with merge base 8e208ad (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Feb 12, 2025
Merged
Merged
Merged
swolchok added a commit that referenced this pull request Feb 12, 2025
@swolchok
build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS
07a6543
Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268
ghstack-source-id: 1608805
ghstack-comment-id: 2652360999
Pull Request resolved: #8398
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2025
@swolchok
Update
d4aaa36
[ghstack-poisoned]
@swolchok
Update
15bc325
[ghstack-poisoned]
@swolchok
Update
6b9b4cc
[ghstack-poisoned]
@swolchok
Update
ca4c14e
[ghstack-poisoned]
@swolchok
Update
372da45
[ghstack-poisoned]
@swolchok
Update
de924fe
[ghstack-poisoned]
@swolchok
Update
a0e9eb9
[ghstack-poisoned]
@swolchok
Update
4878a6b
[ghstack-poisoned]
@swolchok
Update
da6fd97
[ghstack-poisoned]
@swolchok
Update
ef00f3d
[ghstack-poisoned]
@swolchok

swolchok commented Aug 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@swolchok

swolchok commented Aug 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok

swolchok commented Aug 13, 2025

Copy link
Copy Markdown
ContributorAuthor

tests look good

@swolchok
Update
ce099c5
[ghstack-poisoned]
@swolchok
Update
0f13c9f
[ghstack-poisoned]
This was referenced Aug 13, 2025
Merged
Merged
Merged
Merged
Merged
@swolchok
rebase
9fef931
[ghstack-poisoned]
@swolchok
rebase
878efc6
[ghstack-poisoned]
This was referenced Aug 14, 2025
Merged
Merged
@swolchok
rebase
a3b4074
[ghstack-poisoned]
@swolchok
rebase
dec04ee
[ghstack-poisoned]
@swolchok

swolchok commented Aug 15, 2025

Copy link
Copy Markdown
ContributorAuthor

noting CI is good

@swolchok
rebase for land
e5953eb
[ghstack-poisoned]
@swolchok
rebase for land
9561830
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Aug 15, 2025
@swolchok
build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS
9caae78
Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268
ghstack-source-id: 7c31b0c
ghstack-comment-id: 2652360999
Pull Request resolved: #8398
Base automatically changed from gh/swolchok/253/head to mainAugust 15, 2025 18:20
@swolchok
rebase for land
b219e9b
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Aug 15, 2025
@swolchok
build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS
0d27ef9
Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268
ghstack-source-id: 45b12f2
ghstack-comment-id: 2652360999
Pull Request resolved: #8398
@swolchok
swolchok merged commit 035d25c into mainAug 15, 2025
102 of 103 checks passed
@swolchok
swolchok deleted the gh/swolchok/254/head branch August 15, 2025 20:08
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@swolchok@agrima1304
build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS (p…
6b7001d
…ytorch#8398)
Making the structure in this file mirror buck's worldview more closely
when it makes sense. pytorch#8268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbortdbortAwaiting requested review from dbort
@JacobSzwejbkaJacobSzwejbkaAwaiting requested review from JacobSzwejbkaJacobSzwejbka is a code owner
@lucylqlucylqAwaiting requested review from lucylq
@kirklandsignkirklandsignAwaiting requested review from kirklandsign
1 more reviewer
@GregoryComerGregoryComerGregoryComer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@GregoryComer@facebook-github-bot