Skip to content

Bump node version - #187

Closed
krudos wants to merge 0 commit into
react-native-community:masterfrom
krudos:master
Closed

Bump node version#187
krudos wants to merge 0 commit into
react-native-community:masterfrom
krudos:master

Conversation

@krudos

Copy link
Copy Markdown
Contributor

Bump node version to 16.x
as defined in .node-version in react native

@cortinico

Copy link
Copy Markdown
Member

This was discussed here:
#172 (comment)

I'm unsure if we want to bump Node to 16 at this stage as we won't be testing on 14 anymore. But as 18 entered LTS, it's probably worth to switch at this stage

@krudos

Copy link
Copy Markdown
ContributorAuthor

current version of react native support node 16 https://github.com/facebook/react-native/blob/main/.node-version
also this tool that is use to build react native packages needs node 16 https://github.com/callstack/react-native-builder-bob

so it will be great if this could be merge

@gengjiawen

Copy link
Copy Markdown
Member

I am inclined we directly bump to 18

@krudos

Copy link
Copy Markdown
ContributorAuthor

I change it to 18

@cortinico

Copy link
Copy Markdown
Member

I am inclined we directly bump to 18

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

@gengjiawen

gengjiawen commented Nov 23, 2022

Copy link
Copy Markdown
Member

I am inclined we directly bump to 18

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

Node.js 16 will EOL in 2023. 18 will in 2025 with more features and newer v8 (comprehensive js features).
As for old user, they can still use tagged Image as a workaround.

Also if #188 got merged, they can use n to switch node version easily.

facebook-github-bot pushed a commit to react/react-native that referenced this pull request Nov 25, 2022
Summary:
Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/
Node 16 EOL: 2023-09-11
https://nodejs.org/en/blog/announcements/nodejs16-eol/
Node 18 EOL: 2025-04-30
Follow-up
- #34171
- #32980
Ref
- react-native-community/docker-android#187
cc ramonmedel cortinico gengjiawen
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[JavaScript] [Changed] - Bump node version from 16 to 18
Pull Request resolved: #35443
Test Plan: Everything builds and runs as expected
Reviewed By: cipolleschi
Differential Revision: D41531161
Pulled By: cortinico
fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
@cortinico

Copy link
Copy Markdown
Member

As this got merged:
react/react-native#35443

Please go ahead and bump to 16.x

If you need 18 -> Let's merge #188 instead

@krudos

Copy link
Copy Markdown
ContributorAuthor

As this got merged: facebook/react-native#35443

Please go ahead and bump to 16.x

If you need 18 -> Let's merge #188 instead

you mean bump to 18.x ?

@cortinico

Copy link
Copy Markdown
Member

you mean bump to 18.x ?

Nope, I meant bump to 16.x
To clarify again:

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

We want the docker container to run on the minimum supported version of Node, which was bumped from 14 -> 16.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@krudos@cortinico@gengjiawen