Uh oh!
There was an error while loading. Please reload this page.
[CI] bump Node references from 12/14 to 14/16 - #32980
Conversation
facebook-github-bot
commented
Jan 27, 2022
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| "repository": "github:facebook/react-native", | ||
| "engines": { | ||
| "node": ">=12" | ||
| "node": ">=14" |
There was a problem hiding this comment.
This will create a warning or error for users of RN with Node 12. Is it okay to make the breaking change yet?
There was a problem hiding this comment.
@NickGerleman I think it's ok to make it a breaking change, folks should be on current LTS (so 16).
@Saadnajmi it's 14 because on CircleCI we also have a job that tests against the previous LTS (14) hence why the requirement. You can see me bumping that nodeprevlts in this PR
There was a problem hiding this comment.
@NickGerleman I think it's ok to make it a breaking change, folks should be on current LTS (so 16).
Agree here. Plus the current Node version (non lts) is 17.
I think it's totally ok to drop Node 12 (maybe we should add a note in the Changelog for this).
There was a problem hiding this comment.
yeah let me change the changelog entry
There was a problem hiding this comment.
Seems like the changelog entry didn't sync properly, we might need to update this separately when building the changelog
There was a problem hiding this comment.
@ShikaSD interesting - is this because I changed the text of the PR body after the import process was started?
There was a problem hiding this comment.
I think we landed the previous version internally, so we didn't re-import the description
cortinico
left a comment
There was a problem hiding this comment.
Change looks go to me 👍 You can disregard the internal failure as it's an unrelated warning (that gets exported as a error on Github Status).
react-native-bot
commented
Jan 28, 2022
This pull request was successfully merged by @kelset in f1488db. When will my fix make it into a release? | Upcoming Releases |
Summary: Node 16 has been the LTS for quite some time now ([Oct 2021](https://nodejs.org/en/blog/release/v16.13.0/)), so this PR just wants to bring the RN OSS CI up to speed. (I realized that this was needed while doing the same for macos microsoft#997) <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - CI moved to Node 16. Pull Request resolved: react#32980 Test Plan: CI itself is the test � locally no significant changes were experienced. Reviewed By: cortinico Differential Revision: D33821288 Pulled By: ShikaSD fbshipit-source-id: 4480ae1cb909e2b8d0b6abba4db76bbe71f0193e
bump Node references from 12/14 to 14/16 (react#32980)
Summary: Node 16 has been the LTS for quite some time now ([Oct 2021](https://nodejs.org/en/blog/release/v16.13.0/)), so this PR just wants to bring the RN OSS CI up to speed. (I realized that this was needed while doing the same for macos microsoft#997) <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - CI moved to Node 16. Pull Request resolved: react#32980 Test Plan: CI itself is the test � locally no significant changes were experienced. Reviewed By: cortinico Differential Revision: D33821288 Pulled By: ShikaSD fbshipit-source-id: 4480ae1cb909e2b8d0b6abba4db76bbe71f0193e
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - #34171 - #32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: #35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
Summary
Node 16 has been the LTS for quite some time now (Oct 2021), so this PR just wants to bring the RN OSS CI up to speed.
(I realized that this was needed while doing the same for macos microsoft#997)
Changelog
[General] [Changed] - Breaking: moving minimum version of Node expected to 14, and move CI to current LTS(16).
Test Plan
CI itself is the test 🤣 locally no significant changes were experienced.