Uh oh!
There was an error while loading. Please reload this page.
Bump dependency on deprecated-react-native-prop-types - #40869
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Oct 12, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 12, 2023 17:03
fc3d1fc to
55e37f9Comparefacebook-github-bot
commented
Oct 12, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 12, 2023 17:29
55e37f9 to
8aa6aa2Comparefacebook-github-bot
commented
Oct 12, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 12:32
8aa6aa2 to
f54630dComparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 12:32
f54630d to
9e97074Comparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 12:37
9e97074 to
551da0fComparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 12:38
551da0f to
4ad7cabComparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 12:38
4ad7cab to
77dd2bcComparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 13:52
77dd2bc to
c9b49edComparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
Summary: Bumps DRNPT to v5 - the significant change is that this one depends on `react-native/normalize-color: ^0.73.0`, instead of `*`, so is protected from future breaking changes to that package. NOTE: We can't safely include `react-native/normalize-color: ^0.74.0` in the dependency range of DRNPT because `0.74.0` isn't a semver-compliant release (0.74 isn't cut yet), so this will pull 0.73.2 from NPM, which is fine. We may need to publish DRNPT@6 if 0.74 final turns out to contain breaking changes (eg, a Node 20 bump). Changelog: [General][Fixed] Update `deprecated-react-native-prop-types` to remove fragile transitive `*` dependencies. Reviewed By: cortinico, huntie Differential Revision: D50228564
robhoganforce-pushed
the
export-D50228564
branch
from
October 13, 2023 13:56
c9b49ed to
79486c9Comparefacebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50228564 |
facebook-github-bot
commented
Oct 13, 2023
Contributor
This pull request has been merged in f00594b. |
facebook-github-bot pushed a commit
that referenced
this pull request
Oct 14, 2023
Summary: To address the root cause of a recurring issue (#40797, #39692) where breaking changes to `react-native/normalize-colors` would be pulled into old versions of `deprecated-react-native-prop-types`, we recently change the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869). For CI, we generally force `react-native/*` to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently `0.74.1`) isn't semver-compatible with `deprecated-react-native-prop-types`'s dependency (`^0.73.0`), so `npm install` was failing in CI with "no package found". We should be getting `0.73.2` from the public registry in this case. This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more. ## Changelog: [INTERNAL] [FIXED] - CI/Verdaccio: Proxy `react-native/normalize-colors` from NPM for the `deprecated-react-native-prop-types` dependency. Pull Request resolved: #40971 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D50298291 Pulled By: robhogan fbshipit-source-id: 4bf6503108335ffa52654346d1874c217071ff91
lunaleaps pushed a commit
that referenced
this pull request
Nov 3, 2023
Summary: Pull Request resolved: #40869 Bumps DRNPT to v5 - the significant change is that this one depends on `react-native/normalize-color: ^0.73.0`, instead of `*`, so is protected from future breaking changes to that package. NOTE: We can't safely include `react-native/normalize-color: ^0.74.0` in the dependency range of DRNPT because `0.74.0` isn't a semver-compliant release (0.74 isn't cut yet), so this will pull 0.73.2 from NPM, which is fine. We may need to publish DRNPT@6 if 0.74 final turns out to contain breaking changes (eg, a Node 20 bump). Changelog: [General][Fixed] Update `deprecated-react-native-prop-types` to remove fragile transitive `*` dependencies. Reviewed By: huntie Differential Revision: D50228564 fbshipit-source-id: 01aafafad40d9a93d00de2b5f45d2796620b9b5d
This was referenced Nov 23, 2023
This was referenced Jan 8, 2024
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Bumps DRNPT to v5 - the significant change is that this one depends on
react-native/normalize-color: ^0.73.0, instead of*, so is protected from future breaking changes to that package.NOTE: We can't safely include
react-native/normalize-color: ^0.74.0in the dependency range of DRNPT because0.74.0isn't a semver-compliant release (0.74 isn't cut yet), so this will pull 0.73.2 from NPM, which is fine. We may need to publish DRNPT@6 if 0.74 final turns out to contain breaking changes (eg, a Node 20 bump).Changelog:
[General][Fixed] Update
deprecated-react-native-prop-typesto remove fragile transitive*dependencies.Differential Revision: D50228564