Uh oh!
There was an error while loading. Please reload this page.
[RN][iOS] Make the interop-layer work with components with custom name - #41207
Closed
cipolleschi wants to merge 2 commits into
Closed
[RN][iOS] Make the interop-layer work with components with custom name#41207cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
cipolleschiforce-pushed
the
cipolleschi/improve_interop_layer
branch
from
October 26, 2023 15:56
c45845d to
367256cComparefacebook-github-bot
commented
Oct 26, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 3648886 |
javache
self-requested a review
October 27, 2023 12:24
cipolleschiforce-pushed
the
cipolleschi/improve_interop_layer
branch
from
October 27, 2023 13:18
367256c to
1a39d86Comparecipolleschi
marked this pull request as ready for review
October 27, 2023 13:19
facebook-github-bot
commented
Oct 27, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
javache
removed their request for review
October 27, 2023 13:35
This pull request was successfully merged by @cipolleschi in daedbe6. When will my fix make it into a release? | Upcoming Releases |
lunaleaps pushed a commit
that referenced
this pull request
Nov 3, 2023
Summary: This should fix#37905 (comment) When working on react-native-fast-image, we realized that the interop layer does not work for components where the exported name is different from the iOS class. To fix this, we can use the Bridge to retrieve the actual view manager, given the component name. This solution should be much more robust than making assumptions on the ViewManager name, given the ComponentName. On top of that, we realized tha the interop layer was not calling `didSetProps` after setting the props, so we are invoking that. bypass-github-export-checks [iOS][Fixed] - Add support for Components with custom names in the interop layer. Pull Request resolved: #41207 Test Plan: Tested locally on an app created in 0.72 and 0.73 in Bridge and Bridgeless mode. Reviewed By: cortinico Differential Revision: D50698172 Pulled By: cipolleschi fbshipit-source-id: 49aee905418515b0204febbbe6a67c0114f37029
fortmarek pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: This should fix#37905 (comment) When working on react-native-fast-image, we realized that the interop layer does not work for components where the exported name is different from the iOS class. To fix this, we can use the Bridge to retrieve the actual view manager, given the component name. This solution should be much more robust than making assumptions on the ViewManager name, given the ComponentName. On top of that, we realized tha the interop layer was not calling `didSetProps` after setting the props, so we are invoking that. bypass-github-export-checks [iOS][Fixed] - Add support for Components with custom names in the interop layer. Pull Request resolved: #41207 Test Plan: Tested locally on an app created in 0.72 and 0.73 in Bridge and Bridgeless mode. Reviewed By: cortinico Differential Revision: D50698172 Pulled By: cipolleschi fbshipit-source-id: 49aee905418515b0204febbbe6a67c0114f37029
fortmarek added a commit
that referenced
this pull request
Nov 10, 2023
* Make the interop-layer work with components with custom name (#41207) Summary: This should fix#37905 (comment) When working on react-native-fast-image, we realized that the interop layer does not work for components where the exported name is different from the iOS class. To fix this, we can use the Bridge to retrieve the actual view manager, given the component name. This solution should be much more robust than making assumptions on the ViewManager name, given the ComponentName. On top of that, we realized tha the interop layer was not calling `didSetProps` after setting the props, so we are invoking that. bypass-github-export-checks [iOS][Fixed] - Add support for Components with custom names in the interop layer. Pull Request resolved: #41207 Test Plan: Tested locally on an app created in 0.72 and 0.73 in Bridge and Bridgeless mode. Reviewed By: cortinico Differential Revision: D50698172 Pulled By: cipolleschi fbshipit-source-id: 49aee905418515b0204febbbe6a67c0114f37029 * Remove references to RCTBridgeProxy --------- Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
This was referenced Nov 23, 2023
This was referenced Jan 8, 2024
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This should fix
#37905 (comment)
When working on react-native-fast-image, we realized that the interop layer does not work for components where the exported name is different from the iOS class.
To fix this, we can use the Bridge to retrieve the actual view manager, given the component name.
This solution should be much more robust than making assumptions on the ViewManager name, given the ComponentName.
On top of that, we realized tha the interop layer was not calling
didSetPropsafter setting the props, so we are invoking that.Changelog:
[iOS][Fixed] - Add support for Components with custom names in the interop layer.
Test Plan:
Tested locally on an app created in 0.72 and 0.73.
Tested also in bridgeless mode, but it crashing.
We will work on bridgeless support in a separate PR.