Skip to content

[ANDROID] fix: textTransform not working in new arch - #41223

Closed
tarunrajput wants to merge 1 commit into
react:mainfrom
tarunrajput:fix/textTranform-in-new-arch
Closed

[ANDROID] fix: textTransform not working in new arch#41223
tarunrajput wants to merge 1 commit into
react:mainfrom
tarunrajput:fix/textTranform-in-new-arch

Conversation

@tarunrajput

@tarunrajputtarunrajput commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Summary:

Fixes: #39524

Changelog:

[ANDROID] [FIXED] - Fix textTransform not working in new architecture

Test Plan:

Before:
image

After:
image

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 27, 2023
@analysis-bot

analysis-bot commented Oct 27, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a17,657,542+9
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,039,203-12
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 118e651
Branch: main

@NickGerlemanNickGerleman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we can also remove the comment on L231 of TextAttributeProps.java now.

@tarunrajput
tarunrajputforce-pushed the fix/textTranform-in-new-arch branch from 448daf6 to 83d6ac0CompareOctober 28, 2023 09:32
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Oct 31, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman merged this pull request in a2f3fa6.

lunaleaps pushed a commit that referenced this pull request Nov 3, 2023
Summary:
Fixes: #39524
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[ANDROID] [FIXED] - Fix textTransform not working in new architecture
Pull Request resolved: #41223
Test Plan:
**Before:**
<img width="307" alt="image" src="https://github.com/facebook/react-native/assets/34857453/d44e6030-0a49-42c9-be44-cf7541583af0">
**After:**
<img width="307" alt="image" src="https://github.com/facebook/react-native/assets/34857453/fb717cec-72d3-41d7-8c48-4ec9a9ecb16b">
Reviewed By: javache
Differential Revision: D50773216
Pulled By: NickGerleman
fbshipit-source-id: 769bf67f2661ff4ff7b88121493bdd27564458d3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

textTransform style does not work under Android with New Arch

4 participants

@tarunrajput@analysis-bot@facebook-github-bot@NickGerleman