Uh oh!
There was an error while loading. Please reload this page.
Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI - #43049
Closed
cortinico wants to merge 2 commits into
Closed
Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI#43049cortinico wants to merge 2 commits into
cortinico wants to merge 2 commits into
Conversation
facebook-github-bot
commented
Feb 15, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D53812109 |
Base commit: 3a1e769 |
2 tasks
Uh oh!
There was an error while loading. Please reload this page.
cortinicoforce-pushed
the
export-D53812109
branch
from
February 19, 2024 13:30
8bc8cc3 to
7f8d9f0Comparefacebook-github-bot
commented
Feb 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D53812109 |
facebook-github-bot
commented
Feb 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D53812109 |
cortinicoforce-pushed
the
export-D53812109
branch
from
February 19, 2024 15:39
7f8d9f0 to
1340378CompareSummary: Bump CLI version to 13.6.0 ## Changelog: [GENERAL] [CHANGED] - Bump CLI to 13.6.0 Pull Request resolved: react#43093 Test Plan: CI Differential Revision: D53920559 Pulled By: cortinico
… from RNCLI (react#43049) Summary: Pull Request resolved: react#43049 This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109
facebook-github-bot
commented
Feb 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D53812109 |
cortinicoforce-pushed
the
export-D53812109
branch
from
February 19, 2024 15:47
1340378 to
bc9f00eComparefacebook-github-bot
commented
Feb 20, 2024
Contributor
This pull request has been merged in 4ecf57e. |
huntie pushed a commit
that referenced
this pull request
Feb 22, 2024
… from RNCLI (#43049) Summary: Pull Request resolved: #43049 This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109 fbshipit-source-id: 47bc0ea699516993070cfa0127de97853acf8890
This was referenced Apr 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This connects the OnLoad.cpp file used by OSS apps with the
rncli_cxxModuleProvider.This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.
Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI
Differential Revision: D53812109