Uh oh!
There was an error while loading. Please reload this page.
Undo moving of TurboModule to internal and expose utility function for TurboModule.class.isAssignableFrom - #43219
Closed
cortinico wants to merge 1 commit into
Closed
Undo moving of TurboModule to internal and expose utility function for TurboModule.class.isAssignableFrom#43219cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Feb 27, 2024
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tido64
reviewed
Feb 28, 2024
Uh oh!
There was an error while loading. Please reload this page.
facebook-github-botforce-pushed
the
nc/donot-isAssignableFrom-with-TM
branch
from
February 29, 2024 00:35
6de2496 to
f15938bComparefacebook-github-bot
commented
Feb 29, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54280882 |
…r TurboModule.class.isAssignableFrom (#43219) Summary: After discussing with mdvacca, we prefer to undo the change of `TurboModule` package to `.internal` as this is a quite aggressive breaking change for the ecosystem. Moreover: users should not invoke `TurboModule.class.isAssignableFrom` because `TurboModule` is `.internal`. Therefore I'm exposing another API to check if a class is a TurboModule as a static field of `ReactModuleInfo`. ## Changelog: [INTERNAL] - Do not use TurboModule.class.isAssignableFrom Test Plan: Tests are attached Reviewed By: mdvacca, cipolleschi Differential Revision: D54280882 Pulled By: cortinico
facebook-github-botforce-pushed
the
nc/donot-isAssignableFrom-with-TM
branch
from
February 29, 2024 00:36
f15938b to
6d88a77Comparefacebook-github-bot
commented
Feb 29, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54280882 |
facebook-github-bot
commented
Feb 29, 2024
Contributor
@cortinico merged this pull request in 4d982dc. |
huntie pushed a commit
that referenced
this pull request
Mar 4, 2024
…r TurboModule.class.isAssignableFrom (#43219) Summary: After discussing with mdvacca, we prefer to undo the change of `TurboModule` package to `.internal` as this is a quite aggressive breaking change for the ecosystem. Moreover: users should not invoke `TurboModule.class.isAssignableFrom` because `TurboModule` is `.internal`. Therefore I'm exposing another API to check if a class is a TurboModule as a static field of `ReactModuleInfo`. ## Changelog: [INTERNAL] - Do not use TurboModule.class.isAssignableFrom Pull Request resolved: #43219 Test Plan: Tests are attached Reviewed By: mdvacca, cipolleschi Differential Revision: D54280882 Pulled By: cortinico fbshipit-source-id: 9443c8aa23cf70dd5cfe574fe573d83313134358
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After discussing with @dvacca, we prefer to undo the change of TurboModule package to .internal as this is a quite aggressive breaking change for the ecosystem.
Moreover: users should not invoke TurboModule.class.isAssignableFrom because TurboModule is .internal. Therefore I'm exposing another API to check if a class is a TurboModule as a static field of ReactModuleInfo.
Changelog:
[INTERNAL] - Do not use TurboModule.class.isAssignableFrom
Test Plan:
Tests are attached