Skip to content

Expose rrc_textinput via prefab - #43274

Closed
tomekzaw wants to merge 2 commits into
react:mainfrom
tomekzaw:patch-2
Closed

Expose rrc_textinput via prefab#43274
tomekzaw wants to merge 2 commits into
react:mainfrom
tomekzaw:patch-2

Conversation

@tomekzaw

Copy link
Copy Markdown
Contributor

Summary:

The rrc_textinput was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.

Changelog:

[ANDROID] [CHANGED] - Expose rrc_textinput via prefab.

Test Plan:

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 1, 2024
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a18,009,266+5
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,367,671+2
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 1d8dea5
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinicocortinico self-assigned this Mar 4, 2024
@cortinico

Copy link
Copy Markdown
Contributor

@tomekzaw do we need this for RC4? If yes please add a pick request.
Also please note that we're still panning in exposing a single prefab target out of React Native in the future (most likely in 0.75/0.76) so this will be a breaking change for react-native-live-markdown.

@tomekzaw

tomekzaw commented Mar 4, 2024

Copy link
Copy Markdown
ContributorAuthor

do we need this for RC4? If yes please add a pick request.

@cortinico Yes, definitely, I've asked to pick for both PRs here: reactwg/react-native-releases#104 (comment)

Also please note that we're still panning in exposing a single prefab target out of React Native in the future (most likely in 0.75/0.76) so this will be a breaking change for react-native-live-markdown.

A single prefab would be a game-changer! Thanks for letting us know, we will make necessary changes on the libraries' side. Happy to test out the changes via nightly to see if it's working correctly or even contribute that change according to your instructions.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 4, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in adc9e5b.

huntie pushed a commit that referenced this pull request Mar 11, 2024
Summary:
The `rrc_textinput` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[ANDROID] [CHANGED] - Expose `rrc_textinput` via prefab.
Pull Request resolved: #43274
Reviewed By: cipolleschi
Differential Revision: D54482657
Pulled By: cortinico
fbshipit-source-id: ca7f4127f1808f841d88925238666e837de75bd0
This was referenced Jun 28, 2024
@cipolleschicipolleschi mentioned this pull request Jul 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: Software MansionPartner: Software MansionPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tomekzaw@analysis-bot@facebook-github-bot@cortinico