Uh oh!
There was an error while loading. Please reload this page.
Support onActivityResult in Bridgeless - #43351
Closed
arushikesarwani94 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54574139 |
arushikesarwani94force-pushed
the
export-D54574139
branch
from
March 6, 2024 16:36
a69eaca to
72e2bdaComparefacebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54574139 |
Base commit: 3ed0ff3 |
arushikesarwani94force-pushed
the
export-D54574139
branch
from
March 6, 2024 18:12
72e2bda to
dc8c80cComparefacebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54574139 |
arushikesarwani94force-pushed
the
export-D54574139
branch
from
March 6, 2024 18:13
dc8c80c to
a67dedcComparefacebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54574139 |
Summary: Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139
arushikesarwani94force-pushed
the
export-D54574139
branch
from
March 6, 2024 18:28
a67dedc to
889eedfComparefacebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54574139 |
Comment on lines
+632
to
+636
| ReactSoftExceptionLogger.logSoftException( | ||
| TAG, | ||
| new ReactNoCrashSoftException( | ||
| "Tried to access onActivityResult while context is not ready")); | ||
| } |
Collaborator
There was a problem hiding this comment.
Should this be called unconditionally?
ContributorAuthor
There was a problem hiding this comment.
Doesn't this only makes sense in case the context is null ?
facebook-github-bot
commented
Mar 6, 2024
Contributor
This pull request has been merged in c771011. |
3 tasks
huntie pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: #43351 Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139 fbshipit-source-id: f2369077199186ac6ef0187b5dfe7ed95f3b87fc
This was referenced Apr 5, 2024
Merged
arushikesarwani94 added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 18, 2025
…geless Summary: Adding `shouldForwardToReactInstance` check in Bridgeless since it was missed in react#43351 **Changelog:** [ANDROID][FIXED] - Adding `shouldForwardToReactInstance` check in ReactDelegate for Bridgeless Differential Revision: D76908041
facebook-github-bot pushed a commit
that referenced
this pull request
Jun 20, 2025
…geless (#52112) Summary: Pull Request resolved: #52112 Adding `shouldForwardToReactInstance` check in Bridgeless since it was missed in #43351 **Changelog:** [ANDROID][FIXED] - Adding `shouldForwardToReactInstance` check in ReactDelegate for Bridgeless Reviewed By: cortinico, javache Differential Revision: D76908041 fbshipit-source-id: 20b8fce248d8e560ab862cf325b6f8b15be870e3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implement
onActivityResulton BridgelessChangelog:
[Internal] internal
Differential Revision: D54574139