Uh oh!
There was an error while loading. Please reload this page.
Add registerCallableModule types - #43366
Closed
Kudo wants to merge 1 commit into
Closed
Conversation
Kudo
marked this pull request as ready for review
March 7, 2024 14:38
facebook-github-bot
commented
Mar 8, 2024
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
commented
Mar 8, 2024
Contributor
@Kudo can you add a pick request here for 0.74? |
facebook-github-bot
commented
Mar 8, 2024
Contributor
@cortinico merged this pull request in 6bc95b2. |
Kudo
commented
Mar 8, 2024
ContributorAuthor
added, thanks @cortinico! |
huntie pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: `registerCallableModule()` was added from 7f549ec but no typescript types there. this pr tries to add the corresponding types. ## Changelog: [GENERAL] [FIXED] - Add missing `registerCallableModule` TypeScript definitions Pull Request resolved: #43366 Test Plan: patch locally and try to `import { registerCallableModule } from 'react-native';` in a 0.74.0-rc.2 project Reviewed By: fabriziocucci Differential Revision: D54676151 Pulled By: cortinico fbshipit-source-id: cd01f2ebe2d2516b458fae5b2e83cba3d3794455
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
registerCallableModule()was added from 7f549ec but no typescript types there. this pr tries to add the corresponding types.Changelog:
[GENERAL] [FIXED] - Add missing
registerCallableModuleTypeScript definitionsTest Plan:
patch locally and try to
import { registerCallableModule } from 'react-native';in a 0.74.0-rc.2 project