Uh oh!
There was an error while loading. Please reload this page.
Fix component stacks for tsx, ts, and jsx files - #43370
Closed
rickhanlonii wants to merge 1 commit into
Closed
Conversation
Summary: Component stacks with files ending in .ts, .tsx, or .jsx were skipped in LogBox reporting. This diff fixes the regex. Changelog: [General][Fixed] - Support .tsx, .ts, and .jsx in component stacks Differential Revision: D54638526
facebook-github-bot
commented
Mar 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54638526 |
rickhanloniiforce-pushed
the
export-D54638526
branch
from
March 7, 2024 16:49
12ea4ce to
f6c14ecComparefacebook-github-bot
commented
Mar 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54638526 |
rickhanlonii added a commit
to rickhanlonii/react-native
that referenced
this pull request
Mar 7, 2024
Summary: Component stacks with files ending in .ts, .tsx, or .jsx were skipped in LogBox reporting. This diff fixes the regex. Changelog: [General][Fixed] - Support .tsx, .ts, and .jsx in component stacks Differential Revision: D54638526
facebook-github-bot
commented
Mar 8, 2024
Contributor
This pull request has been merged in adaf5eb. |
Titozzz
commented
Mar 8, 2024
Collaborator
I've also requested a cherry pick for 0.73 here => reactwg/react-native-releases#133 |
alfonsocj pushed a commit
that referenced
this pull request
Mar 8, 2024
Summary: Pull Request resolved: #43370 Component stacks with files ending in .ts, .tsx, or .jsx were skipped in LogBox reporting. This diff fixes the regex. Changelog: [General][Fixed] - Support .tsx, .ts, and .jsx in component stacks Reviewed By: yungsters Differential Revision: D54638526 fbshipit-source-id: a5271daaa7b687e8e075be3f94ab9b9c03f79b66
huntie pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: #43370 Component stacks with files ending in .ts, .tsx, or .jsx were skipped in LogBox reporting. This diff fixes the regex. Changelog: [General][Fixed] - Support .tsx, .ts, and .jsx in component stacks Reviewed By: yungsters Differential Revision: D54638526 fbshipit-source-id: a5271daaa7b687e8e075be3f94ab9b9c03f79b66
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Component stacks with files ending in .ts, .tsx, or .jsx were skipped in LogBox reporting. This diff fixes the regex.
Changelog:
[General][Fixed] - Support .tsx, .ts, and .jsx in component stacks
Differential Revision: D54638526