Uh oh!
There was an error while loading. Please reload this page.
Fix bug where absolute nodes were not insetted correctly in certain cases - #43417
Closed
joevilches wants to merge 1 commit into
Closed
Fix bug where absolute nodes were not insetted correctly in certain cases#43417joevilches wants to merge 1 commit into
joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Mar 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54703955 |
joevilches added a commit
to joevilches/yoga
that referenced
this pull request
Mar 11, 2024
…ases Summary: X-link: react/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilchesforce-pushed
the
export-D54703955
branch
from
March 11, 2024 18:55
04e0e4c to
32d1f60Comparefacebook-github-bot
commented
Mar 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54703955 |
…ases (react#43417) Summary: X-link: react/yoga#1593 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilches added a commit
to joevilches/yoga
that referenced
this pull request
Mar 12, 2024
…ases (react#1593) Summary: X-link: react/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955
joevilchesforce-pushed
the
export-D54703955
branch
from
March 12, 2024 01:02
32d1f60 to
4b2f7c6Comparefacebook-github-bot
commented
Mar 12, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54703955 |
facebook-github-bot pushed a commit
to facebook/litho
that referenced
this pull request
Mar 12, 2024
…ases Summary: X-link: react/yoga#1593 X-link: react/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
facebook-github-bot pushed a commit
to react/yoga
that referenced
this pull request
Mar 12, 2024
…ases (#1593) Summary: Pull Request resolved: #1593 X-link: react/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
facebook-github-bot
commented
Mar 12, 2024
Contributor
This pull request has been merged in 3341ab7. |
NickGerleman pushed a commit
to react/yoga
that referenced
this pull request
Mar 13, 2024
…ases (#1593) Summary: Pull Request resolved: #1593 X-link: react/react-native#43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
huntie pushed a commit
that referenced
this pull request
Mar 18, 2024
…ases (#43417) Summary: X-link: react/yoga#1593 Pull Request resolved: #43417 There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening Reviewed By: NickGerleman Differential Revision: D54703955 fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening
Reviewed By: NickGerleman
Differential Revision: D54703955