Uh oh!
There was an error while loading. Please reload this page.
Add @types/react as optional peerDependency on packages that use it - #43509
Closed
acoates-ms wants to merge 3 commits into
Closed
Add @types/react as optional peerDependency on packages that use it#43509acoates-ms wants to merge 3 commits into
acoates-ms wants to merge 3 commits into
Conversation
|
Base commit: 1021448 |
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+10
to
+11
| export type {default} from './js/PopupMenuAndroid'; | ||
| export type {PopupMenuAndroidInstance} from './js/PopupMenuAndroid'; |
facebook-github-bot
commented
Mar 22, 2024
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Mar 25, 2024
Contributor
@NickGerleman merged this pull request in dbf8e3f. |
huntie pushed a commit
that referenced
this pull request
Apr 2, 2024
…43509) Summary: Now that RN is providing TS type information, many of those .d.ts files depend on types from react. In modern packagemanagers (Ex: pnpm) types/react will not be available to RN since it does not declare it as a dependency. I also noticed that the types for react-native-popup-menu-android appear to be pointing to the wrong location. Add types/react as a peerDependency on the packages that have .d.ts files that import from React. Add types/react to peerDependencyMeta with optional:true to prevent users not using TS from requiring types/react. [GENERAL] [ADDED] Added types/react as an optional peerDependency Pull Request resolved: #43509 Reviewed By: cortinico Differential Revision: D55225940 Pulled By: NickGerleman fbshipit-source-id: 4cbab071928cb925baec45f55461559acc9a54e6
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that RN is providing TS type information, many of those .d.ts files depend on types from react. In modern packagemanagers (Ex: pnpm) @types/react will not be available to RN since it does not declare it as a dependency.
I also noticed that the types for react-native-popup-menu-android appear to be pointing to the wrong location.
Summary:
Add @types/react as a peerDependency on the packages that have .d.ts files that import from React.
Add @types/react to peerDependencyMeta with optional:true to prevent users not using TS from requiring @types/react.
Changelog:
[GENERAL] [ADDED] Added @types/react as an optional peerDependency