Uh oh!
There was an error while loading. Please reload this page.
Remove dangerous "9999" version string default - #43516
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 15, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54956661 |
Summary: As titled. This seems dangerous — removing with the motivation that we'd prefer this script to fail during execution than to succeed in publishing `9999`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D54956661
facebook-github-bot
commented
Mar 15, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54956661 |
facebook-github-bot
commented
Mar 15, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54956661 |
facebook-github-bot
commented
Mar 15, 2024
Contributor
This pull request has been merged in d43cdee. |
analysis-bot
commented
Mar 15, 2024
Base commit: e180f80 |
huntie added a commit
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #43516 As titled. This seems dangerous — removing with the motivation that we'd prefer this script to fail during execution than to succeed in publishing `9999`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D54956661 fbshipit-source-id: 23f8d49abd300385dde74871b6d2492ef63f058e
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. This seems dangerous — removing with the motivation that we'd prefer this script to fail during execution than to succeed in publishing
9999.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D54956661