Skip to content

Adjust version parsing in release scripts, fix release dry runs in CI - #43568

Closed
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D55123739
Closed

Adjust version parsing in release scripts, fix release dry runs in CI#43568
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D55123739

Conversation

@huntie

@huntiehuntie commented Mar 20, 2024

Copy link
Copy Markdown
Collaborator

Summary:
Fixes to restore passing CI checks on main after D55027120.

  • Widen validation checks in version utils to accept 0.x.x (as opposed to 0.[not-'0'].x).
  • Use tag: test instead of tag: latest for dry run job params.

Changelog: [Internal]

Differential Revision: D55123739

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 20, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55123739

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55123739

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55123739

@analysis-bot

analysis-bot commented Mar 20, 2024

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a18,125,936+0
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,491,276-1
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: b7c1bd4
Branch: main

@huntiehuntie changed the title Adjust version parsing in release scriptsAdjust version parsing in release scripts, fix release dry runs in CIMar 20, 2024
…#43568)
Summary:
Fixes to restore passing CI checks on main after D55027120.
- Widen validation checks in version utils to accept `0.x.x` (as opposed to `0.[not-'0'].x`).
- Use `tag: test` instead of `tag: latest` for dry run job params.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D55123739
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55123739

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55123739

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 20, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in d03b5dc.

huntie added a commit that referenced this pull request Mar 20, 2024
…#43568)
Summary:
Pull Request resolved: #43568
Fixes to restore passing CI checks on main after D55027120.
- Widen validation checks in version utils to accept `0.x.x` (as opposed to `0.[not-'0'].x`).
- Use `tag: test` instead of `tag: latest` for dry run job params.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D55123739
fbshipit-source-id: 9f76dced4e7aa3ce87d6680cd7687ae443305331
This was referenced Jun 28, 2024
@cipolleschicipolleschi mentioned this pull request Jul 22, 2024
@huntie
huntie deleted the export-D55123739 branch September 9, 2024 12:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot