Uh oh!
There was an error while loading. Please reload this page.
[RN][iOS] Fix static linking for Bridgeless mode - #43846
Conversation
cipolleschi
commented
Apr 4, 2024
@gabrieldonadel I tested this locally and it works. Do you mind test it yourself as well? |
facebook-github-bot
commented
Apr 4, 2024
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
left a comment
There was a problem hiding this comment.
Hi @cipolleschi, amazing work! I just tested this on Expo's repo and it fixes the issues with importing #import <ReactCommon/RCTHost.h>, thanks!
I'm still facing some issues when importing #import <reacthermes/HermesExecutorFactory.h> but we can address that in another PR
facebook-github-bot
commented
Apr 4, 2024
@cipolleschi merged this pull request in 0b6b8e2. |
This pull request was successfully merged by @cipolleschi in 0b6b8e2. When will my fix make it into a release? | How to file a pick request? |
Summary: Working with gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure. When a user tries to import `ReactCommon/RCTHost` in the app delegate, for example, the user ends up with an error and they can't find the files. These changes fixes this by establishing the right folder structure in the static frameworks ## Changelog: [Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks Pull Request resolved: #43846 Test Plan: Tested locally on an app with 0.74. Before: it failed to build. After: it build successfully. Reviewed By: cortinico Differential Revision: D55741581 Pulled By: cipolleschi fbshipit-source-id: 11ac0882d3feea05ef8904d55856ba5704b7a3b8
Summary:
Working with @gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure.
When a user tries to import
ReactCommon/RCTHostin the app delegate, for example, the user ends up with an error and they can't find the files.These changes fixes this by establishing the right folder structure in the static frameworks
Changelog:
[Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks
Test Plan:
Tested locally on an app with 0.74.
Before: it failed to build.
After: it build successfully.