Skip to content

[RN][iOS] Fix static linking for Bridgeless mode - #43846

Closed
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/fix_static_linking_bridgeless
Closed

[RN][iOS] Fix static linking for Bridgeless mode#43846
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/fix_static_linking_bridgeless

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

Summary:

Working with @gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure.
When a user tries to import ReactCommon/RCTHost in the app delegate, for example, the user ends up with an error and they can't find the files.

These changes fixes this by establishing the right folder structure in the static frameworks

Changelog:

[Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks

Test Plan:

Tested locally on an app with 0.74.
Before: it failed to build.
After: it build successfully.

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 4, 2024
@cipolleschi

Copy link
Copy Markdown
ContributorAuthor

@gabrieldonadel I tested this locally and it works. Do you mind test it yourself as well?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadelgabrieldonadel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cipolleschi, amazing work! I just tested this on Expo's repo and it fixes the issues with importing #import <ReactCommon/RCTHost.h>, thanks!
I'm still facing some issues when importing #import <reacthermes/HermesExecutorFactory.h> but we can address that in another PR

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Apr 4, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in 0b6b8e2.

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @cipolleschi in 0b6b8e2.

When will my fix make it into a release? | How to file a pick request?

cortinico pushed a commit that referenced this pull request Apr 8, 2024
Summary:
Working with gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure.
When a user tries to import `ReactCommon/RCTHost` in the app delegate, for example, the user ends up with an error and they can't find the files.
These changes fixes this by establishing the right folder structure in the static frameworks
## Changelog:
[Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks
Pull Request resolved: #43846
Test Plan:
Tested locally on an app with 0.74.
Before: it failed to build.
After: it build successfully.
Reviewed By: cortinico
Differential Revision: D55741581
Pulled By: cipolleschi
fbshipit-source-id: 11ac0882d3feea05ef8904d55856ba5704b7a3b8
@cortinico
cortinico deleted the cipolleschi/fix_static_linking_bridgeless branch June 10, 2024 13:08
This was referenced Jun 28, 2024
@cipolleschicipolleschi mentioned this pull request Jul 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cipolleschi@facebook-github-bot@gabrieldonadel