Uh oh!
There was an error while loading. Please reload this page.
Fix double metro banner in Bridgeless - #43967
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55870640 |
cipolleschiforce-pushed
the
export-D55870640
branch
from
April 8, 2024 13:31
df82b74 to
339b06bComparefacebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55870640 |
Base commit: 7dec625 |
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55870640 |
Summary: Following up #43943, the metro loading banner is presented twice in Bridgeless mode. This happens because both the RCTInstance and the RCTHost are listening to the Reload Command and issuing the instructions to refetch the JSBundle and to present the banner. The RCTInstance should not concern itself with lifecycle events, owned by the RCTHost. ## Changelog: [iOS][Fixed] - Avoid to show Metro Loading banner twice. Reviewed By: cortinico Differential Revision: D55870640
cipolleschiforce-pushed
the
export-D55870640
branch
from
April 8, 2024 16:10
339b06b to
f2d5008Comparefacebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55870640 |
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request has been merged in 64ed820. |
This pull request was successfully merged by @cipolleschi in 64ed820. When will my fix make it into a release? | How to file a pick request? |
cortinico pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: #43967 Following up #43943, the metro loading banner is presented twice in Bridgeless mode. This happens because both the RCTInstance and the RCTHost are listening to the Reload Command and issuing the instructions to refetch the JSBundle and to present the banner. The RCTInstance should not concern itself with lifecycle events, owned by the RCTHost. ## Changelog: [iOS][Fixed] - Avoid to show Metro Loading banner twice. Reviewed By: cortinico Differential Revision: D55870640 fbshipit-source-id: addb67d3226f7d7db20736309172a42fc15f3aa3
This was referenced Apr 9, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Following up #43943, the metro loading banner is presented twice in Bridgeless mode.
This happens because both the RCTInstance and the RCTHost are listening to the Reload Command and issuing the instructions to refetch the JSBundle and to present the banner.
The RCTInstance should not concern itself with lifecycle events, owned by the RCTHost.
Changelog:
[iOS][Fixed] - Avoid to show Metro Loading banner twice.
Reviewed By: cortinico
Differential Revision: D55870640