fix ReactActivity.getReactDelegate().reload() by Kudo · Pull Request #44223 · react/react-native

Kudo · 2024-04-23T18:28:03Z

Summary:

fixing some problem for ReactActivity.getReactDelegate().reload() from #43521:

the reload() does not work for bridge mode on release build

Changelog:

[ANDROID] [FIXED] - Fixed app reloading for ReactActivity.getReactDelegate().reload().

Test Plan:

tried to temporary change toast.show as reload and test from rn-tester

--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt@@ -10,6 +10,7 @@ package com.facebook.react.modules.toast
import android.view.Gravity
import android.widget.Toast
import com.facebook.fbreact.specs.NativeToastAndroidSpec
+import com.facebook.react.ReactActivity
import com.facebook.react.bridge.NativeModule
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.UiThreadUtil
@@ -30,9 +31,11 @@ public class ToastModule(reactContext: ReactApplicationContext) :
)
override public fun show(message: String?, durationDouble: Double) {
- val duration = durationDouble.toInt()- UiThreadUtil.runOnUiThread(- Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() })+// val duration = durationDouble.toInt()+// UiThreadUtil.runOnUiThread(+// Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() })+ val activity = reactApplicationContext.currentActivity as? ReactActivity+ activity?.reactDelegate?.reload()
}
override public fun showWithGravity(

tried for different mode

bridge mode + debug build
bridgeless mode + debug build
bridge mode + release build
bridgeless mode + release build

analysis-bot · 2024-04-23T19:01:39Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,411,011	-11
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,784,348	+4
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 849da21
Branch: main

…ct#44227) Summary: In react#44223 kudo identified the incorrect return type. Differential Revision: D56497700

) Summary: Pull Request resolved: #44227 In #44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a

Kudo · 2024-04-24T13:27:25Z

rebase main since #44227 was landed

facebook-github-bot · 2024-04-30T22:35:11Z

@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

) Summary: Pull Request resolved: #44227 In #44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a

github-actions · 2024-05-01T22:27:34Z

This pull request was successfully merged by @Kudo in 5399223.

^{When will my fix make it into a release? | How to file a pick request?}

facebook-github-bot · 2024-05-01T22:27:34Z

@arushikesarwani94 merged this pull request in 5399223.

Summary: fixing some problem for `ReactActivity.getReactDelegate().reload()` from #43521: - the `reload()` does not work for bridge mode on release build [ANDROID] [FIXED] - Fixed app reloading for `ReactActivity.getReactDelegate().reload()`. Pull Request resolved: #44223 Test Plan: tried to temporary change toast.show as reload and test from rn-tester ```diff --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt @@ -10,6 +10,7 @@ package com.facebook.react.modules.toast import android.view.Gravity import android.widget.Toast import com.facebook.fbreact.specs.NativeToastAndroidSpec +import com.facebook.react.ReactActivity import com.facebook.react.bridge.NativeModule import com.facebook.react.bridge.ReactApplicationContext import com.facebook.react.bridge.UiThreadUtil @@ -30,9 +31,11 @@ public class ToastModule(reactContext: ReactApplicationContext) : ) override public fun show(message: String?, durationDouble: Double) { - val duration = durationDouble.toInt() - UiThreadUtil.runOnUiThread( - Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) +// val duration = durationDouble.toInt() +// UiThreadUtil.runOnUiThread( +// Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) + val activity = reactApplicationContext.currentActivity as? ReactActivity + activity?.reactDelegate?.reload() } override public fun showWithGravity( ``` tried for different mode - [x] bridge mode + debug build - [x] bridgeless mode + debug build - [x] bridge mode + release build - [x] bridgeless mode + release build Reviewed By: fkgozali Differential Revision: D56795975 Pulled By: arushikesarwani94 fbshipit-source-id: 895eab1927ba6db748ebb32c0fd5313f19cf9d1b

…ct#44227) Summary: Pull Request resolved: react#44227 In react#44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a

Summary: fixing some problem for `ReactActivity.getReactDelegate().reload()` from react#43521: - the `reload()` does not work for bridge mode on release build ## Changelog: [ANDROID] [FIXED] - Fixed app reloading for `ReactActivity.getReactDelegate().reload()`. Pull Request resolved: react#44223 Test Plan: tried to temporary change toast.show as reload and test from rn-tester ```diff --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt @@ -10,6 +10,7 @@ package com.facebook.react.modules.toast import android.view.Gravity import android.widget.Toast import com.facebook.fbreact.specs.NativeToastAndroidSpec +import com.facebook.react.ReactActivity import com.facebook.react.bridge.NativeModule import com.facebook.react.bridge.ReactApplicationContext import com.facebook.react.bridge.UiThreadUtil @@ -30,9 +31,11 @@ public class ToastModule(reactContext: ReactApplicationContext) : ) override public fun show(message: String?, durationDouble: Double) { - val duration = durationDouble.toInt() - UiThreadUtil.runOnUiThread( - Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) +// val duration = durationDouble.toInt() +// UiThreadUtil.runOnUiThread( +// Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) + val activity = reactApplicationContext.currentActivity as? ReactActivity + activity?.reactDelegate?.reload() } override public fun showWithGravity( ``` tried for different mode - [x] bridge mode + debug build - [x] bridgeless mode + debug build - [x] bridge mode + release build - [x] bridgeless mode + release build Reviewed By: fkgozali Differential Revision: D56795975 Pulled By: arushikesarwani94 fbshipit-source-id: 895eab1927ba6db748ebb32c0fd5313f19cf9d1b

…ct#44227) Summary: Pull Request resolved: react#44227 In react#44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a

Summary: fixing some problem for `ReactActivity.getReactDelegate().reload()` from react#43521: - the `reload()` does not work for bridge mode on release build ## Changelog: [ANDROID] [FIXED] - Fixed app reloading for `ReactActivity.getReactDelegate().reload()`. Pull Request resolved: react#44223 Test Plan: tried to temporary change toast.show as reload and test from rn-tester ```diff --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.kt @@ -10,6 +10,7 @@ package com.facebook.react.modules.toast import android.view.Gravity import android.widget.Toast import com.facebook.fbreact.specs.NativeToastAndroidSpec +import com.facebook.react.ReactActivity import com.facebook.react.bridge.NativeModule import com.facebook.react.bridge.ReactApplicationContext import com.facebook.react.bridge.UiThreadUtil @@ -30,9 +31,11 @@ public class ToastModule(reactContext: ReactApplicationContext) : ) override public fun show(message: String?, durationDouble: Double) { - val duration = durationDouble.toInt() - UiThreadUtil.runOnUiThread( - Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) +// val duration = durationDouble.toInt() +// UiThreadUtil.runOnUiThread( +// Runnable { Toast.makeText(getReactApplicationContext(), message, duration).show() }) + val activity = reactApplicationContext.currentActivity as? ReactActivity + activity?.reactDelegate?.reload() } override public fun showWithGravity( ``` tried for different mode - [x] bridge mode + debug build - [x] bridgeless mode + debug build - [x] bridge mode + release build - [x] bridgeless mode + release build Reviewed By: fkgozali Differential Revision: D56795975 Pulled By: arushikesarwani94 fbshipit-source-id: 895eab1927ba6db748ebb32c0fd5313f19cf9d1b

Kudo mentioned this pull request Apr 23, 2024
[core] add reloadAppAsync support expo/expo#28400
Merged
3 tasks

javache reviewed Apr 23, 2024
View reviewed changes

Comment threadpackages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java Outdated

arushikesarwani94 mentioned this pull request Apr 23, 2024
Fixing exposing ReactDelegate through ReactActivity for reload() #44227
Closed

arushikesarwani94 reviewed Apr 23, 2024
View reviewed changes

Comment threadpackages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java Outdated

fix ReactActivity.getReactDelegate().reload()
4f5dd70

Kudo force-pushed the @kudo/reload-fix branch from 627b779 to 4f5dd70Compare April 24, 2024 13:26

arushikesarwani94 mentioned this pull request May 1, 2024
[0.74] Fix reload() in RELEASE reactwg/react-native-releases#275
Closed

facebook-github-bot closed this in 5399223May 1, 2024

facebook-github-bot added the Merged This PR has been merged. label May 1, 2024

cipolleschi mentioned this pull request Jun 28, 2024
[CI] Move iOS Executors to M1 #45213
Closed

cipolleschi mentioned this pull request Jun 28, 2024
[Hermes] Bump Hermes #45220
Merged

cipolleschi mentioned this pull request Jul 22, 2024
[RN][0.74]Fix XROS build #45580
Merged

cipolleschi mentioned this pull request Jul 31, 2024
[RN][Hermes] Fore Hermes versions for slices through env var #45840
Merged

cipolleschi mentioned this pull request Jan 23, 2025
[RN][0.74] Fix ruby for CI #48885
Merged

Navigation Menu

Uh oh!

fix ReactActivity.getReactDelegate().reload() - #44223

fix ReactActivity.getReactDelegate().reload()#44223
Kudo wants to merge 1 commit into
react:mainfrom
Kudo:@kudo/reload-fix

Kudo commented Apr 23, 2024•
edited
Loading

Uh oh!

analysis-bot commented Apr 23, 2024•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Kudo commented Apr 24, 2024

Uh oh!

facebook-github-bot commented Apr 30, 2024

Uh oh!

github-actionsBot commented May 1, 2024

Uh oh!

facebook-github-bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Kudo commented Apr 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

analysis-bot commented Apr 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kudo commented Apr 24, 2024

Uh oh!

facebook-github-bot commented Apr 30, 2024

Uh oh!

github-actionsBot commented May 1, 2024

Uh oh!

facebook-github-bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kudo commented Apr 23, 2024•
edited
Loading

analysis-bot commented Apr 23, 2024•
edited
Loading