Skip to content

Fixing exposing ReactDelegate through ReactActivity for reload() - #44227

Closed
arushikesarwani94 wants to merge 1 commit into
react:mainfrom
arushikesarwani94:export-D56497700
Closed

Fixing exposing ReactDelegate through ReactActivity for reload()#44227
arushikesarwani94 wants to merge 1 commit into
react:mainfrom
arushikesarwani94:export-D56497700

Conversation

@arushikesarwani94

@arushikesarwani94arushikesarwani94 commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

Summary: In #44223@Kudo identified the incorrect return type.

Differential Revision: D56497700

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56497700

…ct#44227)
Summary:
In react#44223 kudo identified the incorrect return type.
Differential Revision: D56497700
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56497700

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a19,410,908+7
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a22,784,326-1
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 995d5b8
Branch: main

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Apr 24, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in e25860f.

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @arushikesarwani94 in e25860f.

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request May 1, 2024
)
Summary:
Pull Request resolved: #44227
In #44223 kudo identified the incorrect return type.
Reviewed By: christophpurrer, philIip
Differential Revision: D56497700
fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request May 6, 2024
…ct#44227)
Summary:
Pull Request resolved: react#44227
In react#44223 kudo identified the incorrect return type.
Reviewed By: christophpurrer, philIip
Differential Revision: D56497700
fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…ct#44227)
Summary:
Pull Request resolved: react#44227
In react#44223 kudo identified the incorrect return type.
Reviewed By: christophpurrer, philIip
Differential Revision: D56497700
fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
This was referenced Jun 28, 2024
@cipolleschicipolleschi mentioned this pull request Jul 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@arushikesarwani94@facebook-github-bot@analysis-bot