Skip to content

fix(react-native-codegen): scripts require yargs - #45995

Merged
blakef merged 1 commit into
0.75-stablefrom
tido/pnpm/add-missing-yargs-0.75
Aug 19, 2024
Merged

fix(react-native-codegen): scripts require yargs#45995
blakef merged 1 commit into
0.75-stablefrom
tido/pnpm/add-missing-yargs-0.75

Conversation

@tido64

Copy link
Copy Markdown
Collaborator

Summary:

Android fails to build in a pnpm monorepo setup because yargs cannot be found:

% yarn android
info Installing the app...
> Configure project :app
WARNING: The option setting 'android.jetifier.ignorelist=hermes-android' is experimental.
Signing config for 'release' build type not found; reusing debug config
> Task :react-native-webapis_web-storage:generateCodegenSchemaFromJavaScript FAILED
28 actionable tasks: 6 executed, 22 up-to-date
node:internal/modules/cjs/loader:1148
throw err;
^
Error: Cannot find module 'yargs'
Require stack:
- /~/node_modules/.store/@react-native-codegen-virtual-39ff8dcc54/package/lib/cli/combine/combine-js-to-schema-cli.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
at Module._load (node:internal/modules/cjs/loader:986:27)
at Module.require (node:internal/modules/cjs/loader:1233:19)
at require (node:internal/modules/helpers:179:18)

Changelog:

[GENERAL] [FIXED] - Fix codegen failing in a pnpm monorepo because of missing yargs

Test Plan:

Tested in microsoft/rnx-kit#3290

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Aug 13, 2024
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a20,710,654-644,202
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a23,912,667-637,324
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: fcd526d
Branch: main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: MicrosoftPartner: MicrosoftPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tido64@analysis-bot@cortinico@blakef@facebook-github-bot