Skip to content

Effect Hook page - #117

Merged
jhonmike merged 10 commits into
reactjs:masterfrom
WeslleyNasRocha:hooks/effect
Mar 3, 2019
Merged

Effect Hook page#117
jhonmike merged 10 commits into
reactjs:masterfrom
WeslleyNasRocha:hooks/effect

Conversation

@WeslleyNasRocha

@WeslleyNasRochaWeslleyNasRocha commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Coisas a fazer

  • Traduzir a parte principal do texto
  • Terminar tradução
  • Ajeitar pontuações
  • Traduzir menu lateral

@netlify

netlifyBot commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit 1ea799e

https://deploy-preview-117--pt-br-reactjs.netlify.com

@WeslleyNasRochaWeslleyNasRocha mentioned this pull request Feb 20, 2019
Closed
90 tasks
@WeslleyNasRochaWeslleyNasRocha changed the title [WIP] Effect Hook pageEffect Hook page [minor wip]Feb 20, 2019
@halian-vilelahalian-vilela added the work in progress Author opened the pull-request but it's still being worked on label Feb 21, 2019
@halian-vilelahalian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
halian-vilela
halian-vilela suggested changes Feb 21, 2019
View reviewed changes

@halian-vilelahalian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oi @WeslleyNasRocha

Obrigado pela tradução, adicionei algumas correções, principalmente de acentos e uma ou outra correção semântica para facilitar o entendimento.

Ainda não revisei 100% mas não vou ter tempo de continuar agora.

Mais no final da tarde eu adiciono o restante das considerações.

Até logo!

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
@halian-vilelahalian-vilela added needs author response Changes requested needing author's input needs +1 Needs another approval before merging labels Feb 21, 2019
@halian-vilelahalian-vilela mentioned this pull request Feb 22, 2019
Closed
halian-vilela
halian-vilela suggested changes Feb 23, 2019
View reviewed changes

@halian-vilelahalian-vilela left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!

Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.

Muito obrigado pelo esforço, esse não foi um texto fácil!

Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?

Fico no aguardo!

Abraços!

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/nav.yml Outdated
@glaucia86glaucia86 removed the needs +1 Needs another approval before merging label Feb 25, 2019
WeslleyNasRocha
WeslleyNasRocha commented Feb 25, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
halian-vilelaand others added 4 commits February 25, 2019 12:43
@halian-vilela@WeslleyNasRocha
Apply suggestions from code review
48fe251
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@WeslleyNasRocha
Update hooks-effect.md
ffc53f4
@halian-vilela@WeslleyNasRocha
Update content/docs/hooks-effect.md
5f06974
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@WeslleyNasRocha
Update hooks-effect.md
b41ffd1
@WeslleyNasRochaWeslleyNasRocha changed the title Effect Hook page [minor wip]Effect Hook pageFeb 25, 2019
@WeslleyNasRocha

WeslleyNasRocha commented Feb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!

Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.

Muito obrigado pelo esforço, esse não foi um texto fácil!

Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?

Fico no aguardo!

Abraços!

É realmente foi um texto bem grandezinho, ja removi o wip do titulo e ja apliquei algumas correções que eu vi também.
Obrigado pelo tempo de revisar tudo 😄

@halian-vilelahalian-vilela added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input work in progress Author opened the pull-request but it's still being worked on labels Feb 25, 2019
halian-vilela
halian-vilela previously approved these changes Feb 25, 2019
View reviewed changes
@halian-vilela

halian-vilela commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!
Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.
Muito obrigado pelo esforço, esse não foi um texto fácil!
Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?
Fico no aguardo!
Abraços!

É realmente foi um texto bem grandezinho, ja removi o wip do titulo e ja apliquei algumas correções que eu vi também.
Obrigado pelo tempo de revisar tudo 😄

Fantástico! @WeslleyNasRocha obrigado você pela tradução.

Vamos só esperar mais um revisor dar uma olhada e logo aceitaremos sua contribuição.

Abraços!

jhonmike
jhonmike previously approved these changes Feb 28, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Jhon Mike@WeslleyNasRocha
Apply suggestions from code review
36b4262
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
Jhon Mike@WeslleyNasRocha
Update content/docs/hooks-effect.md
1ea799e
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@glaucia86

glaucia86 commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

@halian-vilela aprovei confiando na sua revisão. Se puder aprovar e mergear.

cc: @WeslleyNasRocha muito obrigada pela sua excelente Contribuição. Da minha parte:

LGTM 👍

@jhonmike

jhonmike commented Mar 3, 2019

Copy link
Copy Markdown
Member

Parabéns pela contribuição, @WeslleyNasRocha! Vou efetuar o merge, pois, já temos duas aprovações :) 🚀

@jhonmike
jhonmike merged commit a401fe7 into reactjs:masterMar 3, 2019
@jhonmikejhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging 💪 long page - more than 100 lines Long page labels Mar 3, 2019
@tibuurciotibuurcio mentioned this pull request Mar 7, 2019
Closed
13 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@WeslleyNasRochaJhon Mike
Effect Hook page (reactjs#117)
579c757
* wip
* side nav text
* 1 version
* reactjs#119
* Apply suggestions from code review
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
* Update hooks-effect.md
* Update content/docs/hooks-effect.md
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
* Update hooks-effect.md
* Apply suggestions from code review
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
* Update content/docs/hooks-effect.md
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike approved these changes
+2 more reviewers
@glaucia86glaucia86glaucia86 approved these changes
@halian-vilelahalian-vilelahalian-vilela left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WeslleyNasRocha@halian-vilela@glaucia86@jhonmike