Uh oh!
There was an error while loading. Please reload this page.
Allow power10-vector feature in PowerPC - #104704
Merged
Merged
Conversation
rustbot
commented
Nov 22, 2022
Collaborator
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
| const POWERPC_ALLOWED_FEATURES: &[(&str, Option<Symbol>)] = &[ | ||
| // tidy-alphabetical-start | ||
| ("altivec", Some(sym::powerpc_target_feature)), | ||
| ("power10-vector", Some(sym::powerpc_target_feature)), |
Member
There was a problem hiding this comment.
Can you move this below power10-vector, so they're in order?
ContributorAuthor
There was a problem hiding this comment.
I think they're in alphabetical order, because power10-vector < power8-altivec (1 < 8) ?
jackh726
commented
Nov 23, 2022
Member
@bors r+ |
bors
commented
Nov 23, 2022
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 24, 2022
Allow power10-vector feature in PowerPC Note that we don't have `power10-altivec`: https://github.com/llvm/llvm-project/blob/57fd7ffefffae313de800fecdd9f095a17bfd4ea/llvm/lib/Target/PowerPC/PPC.td#L277-L280
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 24, 2022
Allow power10-vector feature in PowerPC Note that we don't have `power10-altivec`: https://github.com/llvm/llvm-project/blob/57fd7ffefffae313de800fecdd9f095a17bfd4ea/llvm/lib/Target/PowerPC/PPC.td#L277-L280
This was referenced Nov 24, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty) - rust-lang#104704 (Allow power10-vector feature in PowerPC) - rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names) - rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint) - rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings) - rust-lang#104780 (make `error_reported` check for delayed bugs) - rust-lang#104782 (Bump the const eval step limit) - rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS) - rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers) - rust-lang#104820 (Remove normalize_projection_type) - rust-lang#104822 (with_query_mode -> new) Failed merges: - rust-lang#104716 (move 2 candidates into builtin candidate) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that we don't have
power10-altivec:https://github.com/llvm/llvm-project/blob/57fd7ffefffae313de800fecdd9f095a17bfd4ea/llvm/lib/Target/PowerPC/PPC.td#L277-L280