Skip to content

rustdoc: simplify .search-results-title CSS - #104792

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/crate-search-title-display
Nov 25, 2022
Merged

rustdoc: simplify .search-results-title CSS#104792
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/crate-search-title-display

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

By using display: flex, we still get the never-wrapping layout with #crate-search-div maxing out and truncating its text. The title itself winds up always filling its parent, but since #crate-search doesn't have flex-grow set, it won't fill available space.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 23, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle
notriddleforce-pushed the notriddle/crate-search-title-display branch from a90f6c6 to 2185f49CompareNovember 23, 2022 21:30
By using `display: flex`, we still get the never-wrapping layout with
`#crate-search-div` maxing out and truncating its text. The title itself
winds up always filling its parent, but since `#crate-search` doesn't have
`flex-grow` set, it won't fill available space.
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2185f49 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 24, 2022
…itle-display, r=GuillaumeGomez
rustdoc: simplify `.search-results-title` CSS
By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 24, 2022
…itle-display, r=GuillaumeGomez
rustdoc: simplify `.search-results-title` CSS
By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
This was referenced Nov 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2022
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty)
- rust-lang#104704 (Allow power10-vector feature in PowerPC)
- rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names)
- rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint)
- rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings)
- rust-lang#104780 (make `error_reported` check for delayed bugs)
- rust-lang#104782 (Bump the const eval step limit)
- rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS)
- rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers)
- rust-lang#104820 (Remove normalize_projection_type)
- rust-lang#104822 (with_query_mode -> new)
Failed merges:
- rust-lang#104716 (move 2 candidates into builtin candidate)
- rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ed2d936 into rust-lang:masterNov 25, 2022
@rustbotrustbot added this to the 1.67.0 milestone Nov 25, 2022
@notriddle
notriddle deleted the notriddle/crate-search-title-display branch November 25, 2022 03:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@notriddle@rustbot@GuillaumeGomez@bors@jsha