Skip to content

Avoid unsafe code in to_ascii_[lower/upper]case() - #106922

Merged
bors merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:patch-5
Jan 17, 2023
Merged

Avoid unsafe code in to_ascii_[lower/upper]case()#106922
bors merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:patch-5

Conversation

@ChayimFriedman2

@ChayimFriedman2ChayimFriedman2 commented Jan 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot

rustbot commented Jan 15, 2023

Copy link
Copy Markdown
Collaborator

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2023
@rustbot

rustbot commented Jan 15, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@workingjubilee

workingjubilee commented Jan 17, 2023

Copy link
Copy Markdown
Member

Yeah, these ultimately delegate to the same functions, as far as I can tell.

@bors r+

@bors

bors commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 8dbc878 has been approved by workingjubilee

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@Dylan-DPCDylan-DPC mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge ofrust-lang#106984- Dylan-DPC:rollup-xce8263, r=Dylan-DPC
38a76f3
Rollup of 5 pull requests
Successful merges:
- rust-lang#101698 (Constify `TypeId` ordering impls)
- rust-lang#106148 (Fix unused_parens issue for higher ranked function pointers)
- rust-lang#106922 (Avoid unsafe code in `to_ascii_[lower/upper]case()`)
- rust-lang#106951 (Remove ineffective run of SimplifyConstCondition)
- rust-lang#106962 (Fix use suggestion span)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1b2d595 into rust-lang:masterJan 17, 2023
@rustbotrustbot added this to the 1.68.0 milestone Jan 17, 2023
@ChayimFriedman2
ChayimFriedman2 deleted the patch-5 branch January 18, 2023 10:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuvipercuviper

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ChayimFriedman2@rustbot@workingjubilee@bors@cuviper