Uh oh!
There was an error while loading. Please reload this page.
Fix use suggestion span - #106962
Merged
Merged
Conversation
rustbot
commented
Jan 17, 2023
Collaborator
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
workingjubilee
commented
Jan 17, 2023
Member
Is there a test for the |
compiler-errors
commented
Jan 17, 2023
ContributorAuthor
@workingjubilee that was fixed in #106175, but it's not currently a structured/apply-able suggestion due to the spans not being tracked correctly. |
compiler-errors
commented
Jan 17, 2023
ContributorAuthor
On nightly: |
compiler-errorsforce-pushed
the
use-sugg-span
branch
from
January 17, 2023 02:51
1ceb812 to
12bdb05Compare
This comment has been minimized.
This comment has been minimized.
compiler-errorsforce-pushed
the
use-sugg-span
branch
from
January 17, 2023 03:09
12bdb05 to
2172577Compareworkingjubilee
commented
Jan 17, 2023
Member
No problem, just thought I'd ask, as I had been fiddling around with a few cases of this. |
oli-obk
commented
Jan 17, 2023
Contributor
@bors r+ rollup |
bors
commented
Jan 17, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2023
Rollup of 5 pull requests Successful merges: - rust-lang#101698 (Constify `TypeId` ordering impls) - rust-lang#106148 (Fix unused_parens issue for higher ranked function pointers) - rust-lang#106922 (Avoid unsafe code in `to_ascii_[lower/upper]case()`) - rust-lang#106951 (Remove ineffective run of SimplifyConstCondition) - rust-lang#106962 (Fix use suggestion span) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#106954