Skip to content

Rollup of 5 pull requests - #106984

Merged
bors merged 14 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-xce8263
Jan 17, 2023
Merged

Rollup of 5 pull requests#106984
bors merged 14 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-xce8263

Conversation

@Dylan-DPC

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

chenyukangand others added 14 commits January 14, 2023 17:11
There are no constant conditions at this stage.
…=scottmcm
Constify `TypeId` ordering impls
Tracking issue: rust-lang#101871
Adding const ordering to `TypeId` allows rtti crates to optimize some casting scenarios (without transmuting to `u64`). This would also prevent these crates from breaking if the underlying type is changed from `u64` to something different.
Feature gate: `#![feature(const_cmp_type_id)]`
…d, r=lcnr
Fix unused_parens issue for higher ranked function pointers
fixesrust-lang#105061
r? `@lcnr`
…jubilee
Avoid unsafe code in `to_ascii_[lower/upper]case()`
…-obk
Remove ineffective run of SimplifyConstCondition
There are no constant conditions at this stage.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 17, 2023
@Dylan-DPC

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit e6e7c39 has been approved by Dylan-DPC

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@bors

bors commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e6e7c39 with merge 38a76f3...

@bors

bors commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 38a76f3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2023
@bors
bors merged commit 38a76f3 into rust-lang:masterJan 17, 2023
@rustbotrustbot added this to the 1.68.0 milestone Jan 17, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#Perf Build Sha
#10696240fcf3aa117bfeda8b284f1d08f7bdded374d02b
#10695120a042a2dac79517a8af42b139ad4729f8198293
#10692209021f19d79b2263d4875f66850dd38d59c5522a
#10614800985cb01cf5415d70b153dd88ef8be514ce00d8
#101698042beca2f0e97bfbe4a173fa01418605e21d2125

previous master: f34cc658eb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@Dylan-DPC
Dylan-DPC deleted the rollup-xce8263 branch January 17, 2023 17:49
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (38a76f3): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.3%[0.2%, 0.5%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]3
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-1.4%[-2.1%, -0.7%]2
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-1.4%[-2.1%, -0.7%]2

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Dylan-DPC@bors@rust-timer@rustbot@chenyukang@ChayimFriedman2@tmiasko@onestacked@compiler-errors