Skip to content

don't into self - #108104

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:into
Feb 17, 2023
Merged

don't into self#108104
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:into

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

don't into()-convert types to themselves

@rustbot

Copy link
Copy Markdown
Collaborator

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 15, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@matthiaskrgr
matthiaskrgrforce-pushed the into branch 3 times, most recently from 92c5682 to c75ab7aCompareFebruary 15, 2023 23:34
Comment threadsrc/librustdoc/clean/utils.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do

Suggested change
GenericArgs::AngleBracketed{args: args.into(),bindings: bindings}
GenericArgs::AngleBracketed{args: args.into(), bindings }

@compiler-errors

Copy link
Copy Markdown
Contributor

r=me with nit

don't into()-convert types to themselves
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r=compiler-errors

@bors

bors commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit a1a6588 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#104068 (rustdoc: Add PartialOrd trait to doc comment explanation)
- rust-lang#107489 (Implement partial support for non-lifetime binders)
- rust-lang#107905 (Pass arguments to `x` subcommands with `--`)
- rust-lang#108009 (Move some tests)
- rust-lang#108086 (wasm: Register the `relaxed-simd` target feature)
- rust-lang#108104 (don't into self)
- rust-lang#108133 (Small cleanups around `EarlyBinder`)
- rust-lang#108136 (Do not ICE on unmet trait alias impl bounds)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9b2ee41 into rust-lang:masterFeb 17, 2023
@rustbotrustbot added this to the 1.69.0 milestone Feb 17, 2023
@matthiaskrgr
matthiaskrgr deleted the into branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@rustbot@compiler-errors@bors@mejrs@nagisa