Skip to content

Do not ICE on unmet trait alias impl bounds - #108136

Merged
bors merged 2 commits into
rust-lang:masterfrom
eggyal:unmet_trait_alias_bound_on_generic_impl
Feb 17, 2023
Merged

Do not ICE on unmet trait alias impl bounds#108136
bors merged 2 commits into
rust-lang:masterfrom
eggyal:unmet_trait_alias_bound_on_generic_impl

Conversation

@eggyal

Copy link
Copy Markdown
Contributor

Fixes#108132

I've also added some documentation to the impl_def_id field of DerivedObligationCause to try and minimise the risk of such errors in future.

r? @compiler-errors

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2023
@eggyal
eggyalforce-pushed the unmet_trait_alias_bound_on_generic_impl branch from 22492df to 64b6000CompareFebruary 16, 2023 20:32
Comment threadcompiler/rustc_middle/src/traits/mod.rs Outdated
@eggyal
eggyalforce-pushed the unmet_trait_alias_bound_on_generic_impl branch from 64b6000 to 55d449fCompareFebruary 16, 2023 22:18
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 55d449f has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#104068 (rustdoc: Add PartialOrd trait to doc comment explanation)
- rust-lang#107489 (Implement partial support for non-lifetime binders)
- rust-lang#107905 (Pass arguments to `x` subcommands with `--`)
- rust-lang#108009 (Move some tests)
- rust-lang#108086 (wasm: Register the `relaxed-simd` target feature)
- rust-lang#108104 (don't into self)
- rust-lang#108133 (Small cleanups around `EarlyBinder`)
- rust-lang#108136 (Do not ICE on unmet trait alias impl bounds)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ecdb7bc into rust-lang:masterFeb 17, 2023
@rustbotrustbot added this to the 1.69.0 milestone Feb 17, 2023
@eggyal
eggyal deleted the unmet_trait_alias_bound_on_generic_impl branch February 19, 2023 11:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE when calling method on generic impl constrained by unmet trait alias

4 participants

@eggyal@compiler-errors@bors@rustbot