Rollup of 8 pull requests by matthiaskrgr · Pull Request #108145 · rust-lang/rust

matthiaskrgr · 2023-02-16T23:19:38Z

Successful merges:

rustdoc: Add PartialOrd trait to doc comment explanation #104068 (rustdoc: Add PartialOrd trait to doc comment explanation)
Implement partial support for non-lifetime binders #107489 (Implement partial support for non-lifetime binders)
Pass arguments to x subcommands with -- #107905 (Pass arguments to x subcommands with --)
Move some tests #108009 (Move some tests)
wasm: Register the relaxed-simd target feature #108086 (wasm: Register the relaxed-simd target feature)
don't into self #108104 (don't into self)
Small cleanups around EarlyBinder #108133 (Small cleanups around EarlyBinder)
Do not ICE on unmet trait alias impl bounds #108136 (Do not ICE on unmet trait alias impl bounds)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This WebAssembly proposal is likely to reach stage 4 soon so this starts the support in Rust for the proposal by adding a target feature that can be enabled via attributes for the stdarch project to bind the intrinsics.

don't into()-convert types to themselves

…e, r=scottmcm rustdoc: Add PartialOrd trait to doc comment explanation The doc comments for [partial_cmp](https://github.com/rust-lang/rust/blob/master/library/core/src/iter/traits/iterator.rs#L3478) is the exact same as the doc comment for [cmp](https://github.com/rust-lang/rust/blob/master/library/core/src/iter/traits/iterator.rs#L3413). This PR adds to the description `partial_cmp` to disambiguate the description from `cmp.`

…rs, r=cjgillot Implement partial support for non-lifetime binders This implements support for non-lifetime binders. It's pretty useless currently, but I wanted to put this up so the implementation can be discussed. Specifically, this piggybacks off of the late-bound lifetime collection code in `rustc_hir_typeck::collect::lifetimes`. This seems like a necessary step given the fact we don't resolve late-bound regions until this point, and binders are sometimes merged. Q: I'm not sure if I should go along this route, or try to modify the earlier nameres code to compute the right bound var indices for type and const binders eagerly... If so, I'll need to rename all these queries to something more appropriate (I've done this for `resolve_lifetime::Region` -> `resolve_lifetime::ResolvedArg`) cc rust-lang/types-team#81 r? `@ghost`

…san68 Pass arguments to `x` subcommands with `--` Fixesrust-lang#107375 Any arguments passed to `x` following `--` are removed and not parsed, instead passed down to subcommands (just the ones listed in the issue, not sure if more are needed). This does not remove the existing `--args` and `--test-args` behaviour, just extends it. It's also not documented in the help, not sure of the best way to format it. r? `@jyn514`

Move some tests r? `@petrochenkov`

…ture, r=eholk wasm: Register the `relaxed-simd` target feature This WebAssembly proposal is likely to reach stage 4 soon so this starts the support in Rust for the proposal by adding a target feature that can be enabled via attributes for the stdarch project to bind the intrinsics.

don't into self don't into()-convert types to themselves

…r=compiler-errors Small cleanups around `EarlyBinder` Cleaning up a few things that were brought up by `@lcnr` in reviewing rust-lang#106696: - [make `issue33140_self_ty` query return `Option<EarlyBinder<Ty>>`](rust-lang#106696 (comment)) - [small style improvement](rust-lang#106696 (comment))

…generic_impl, r=compiler-errors Do not ICE on unmet trait alias impl bounds Fixesrust-lang#108132 I've also added some documentation to the `impl_def_id` field of `DerivedObligationCause` to try and minimise the risk of such errors in future. r? `@compiler-errors`

matthiaskrgr · 2023-02-16T23:20:00Z

@bors r+ rollup=never p=8

bors · 2023-02-16T23:20:02Z

📌 Commit ecdb7bc has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-02-17T01:14:43Z

⌛ Testing commit ecdb7bc with merge ea21839...

bors · 2023-02-17T04:45:08Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ea21839 to master...

rust-timer · 2023-02-17T04:47:25Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#108136	f45e6f16eba27ec556668c0fe7e2d4d09fb9a348
#108133	535a755e10e17436798acbd1a0dd5f094b5408be
#108104	bea1c5c11ae23066ae5e30e9c30088dd93d6b054
#108086	bd870825b42e0f21da26bd6ab5a03a8a2f04f9dd
#108009	dd9e1de8d6b651104df2140f7e94f3a740cbebd4
#107905	5bef9c75de1a08729ad83ec093c554c58b0be05f
#107489	c54b050de443856229bc09764fa16cc0231fa3a9
#104068	1c6c95181e1c5b2a1129b5716be9d0ad70395a40

previous master: 947b696ce0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-02-17T07:11:43Z

Finished benchmarking commit (ea21839): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.8%, 1.3%]	3
Regressions ❌ (secondary)	4.0%	[3.0%, 5.5%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[0.8%, 1.3%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[1.5%, 4.4%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

clubby789and others added 23 commits February 10, 2023 21:40

Pass arguments to x subcommands with --
8bd79fd

wasm: Register the relaxed-simd target feature
d90f7df
This WebAssembly proposal is likely to reach stage 4 soon so this starts the support in Rust for the proposal by adding a target feature that can be enabled via attributes for the stdarch project to bind the intrinsics.

Add feature gate for non_lifetime_binders
262a344

Rename some region-specific stuff
eff2cb7

Make things actually work
52f8235

Be better about bound vars
3f521b3

A bit more work on late-bound consts
915703c

Deny some late-bound ty/ct in some positions, add tests
95f35fe

Move tests
d75e43c

don't into self
a1a6588
don't into()-convert types to themselves

make issue33140_self_ty return Option<EarlyBinder<Ty>>
d659c7c

fix ugly skip_binder
382ade6

rustdoc: Update the description to include PartialOrd elements
ced9629

Do not ICE on unmet trait alias impl bounds
a1468ae

Clarify DerivedObligationCause may hold alias id
55d449f

Rollup merge ofrust-lang#108009- c410-f3r:moar-tests, r=petrochenkov
ee07df9
Move some tests r? `@petrochenkov`

Rollup merge ofrust-lang#108104- matthiaskrgr:into, r=compiler-errors
9b2ee41
don't into self don't into()-convert types to themselves

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2023

bors merged commit ea21839 into rust-lang:masterFeb 17, 2023

rustbot added this to the 1.69.0 milestone Feb 17, 2023

This was referenced Feb 17, 2023
Stabilize anonymous_lifetime_in_impl_trait#107378
Closed
Switch to EarlyBinder for type_of query #107753
Merged
Migrate x to using clap#108083
Closed
Split x setup sub-actions to CLI arguments (Clap edition) #108135
Closed

matthiaskrgr mentioned this pull request Aug 15, 2023
ICE: 'is_trivially_sized' applied to unexpected type#114872
Closed

matthiaskrgr mentioned this pull request Nov 18, 2023
ice: non_lifetime_binders: bound types encountered in structurally_relate_tys#118038
Open

matthiaskrgr mentioned this pull request Dec 24, 2023
ICE: predicates_of.rs: no entry found for key#119275
Closed

matthiaskrgr mentioned this pull request Jan 1, 2024
ICE: no entry found for key, expr.rs#119489
Closed

matthiaskrgr mentioned this pull request Feb 22, 2024
ICE: could not resolve DefId#121422
Closed

matthiaskrgr deleted the rollup-bgadak1 branch March 16, 2024 18:18

matthiaskrgr mentioned this pull request Mar 27, 2024
ICE: unexpected infer type#123140
Open

Navigation Menu

Uh oh!

Uh oh!

Rollup of 8 pull requests - #108145

Rollup of 8 pull requests#108145
bors merged 23 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-bgadak1

matthiaskrgr commented Feb 16, 2023

Uh oh!

matthiaskrgr commented Feb 16, 2023

Uh oh!

bors commented Feb 16, 2023

Uh oh!

bors commented Feb 17, 2023

Uh oh!

bors commented Feb 17, 2023

Uh oh!

rust-timer commented Feb 17, 2023

Uh oh!

rust-timer commented Feb 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Feb 16, 2023

Uh oh!

matthiaskrgr commented Feb 16, 2023

Uh oh!

bors commented Feb 16, 2023

Uh oh!

bors commented Feb 17, 2023

Uh oh!

bors commented Feb 17, 2023

Uh oh!

rust-timer commented Feb 17, 2023

Uh oh!

rust-timer commented Feb 17, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants