Uh oh!
There was an error while loading. Please reload this page.
Always set RUSTC_BOOTSTRAP with x doc - #109667
Conversation
rustbot
commented
Mar 27, 2023
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
| cmd.env("RUSTC_BOOTSTRAP", "1"); | ||
| } | ||
| // We need to validate nightly features, even on the stable channel. | ||
| // Set this unconditionally as the stage0 compiler may be being used to |
There was a problem hiding this comment.
| // Set this unconditionally as the stage0 compiler may be being used to | |
| // Set this unconditionally as the stage0 compiler may be be used to |
There was a problem hiding this comment.
Isn't may be being used correct? I was trying to write in the present tense and I think may be used would be future tense
There was a problem hiding this comment.
I'm not a native speaker. I've first made this comment because it sounded wrong to me, but according to the internet it is correct use although people do say that it's not very commonly used.
(edit: and yes I wanted to suggest may be used instead of may be be used)
There was a problem hiding this comment.
AFAIK they both correct. In our particular use case may be being used fits better.
onur-ozkan
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix :)
onur-ozkan
commented
Mar 27, 2023
@bors r+ rollup |
bors
commented
Mar 27, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108548 (Clarify the 'use a constant in a pattern' error message) - rust-lang#109565 (Improve documentation for E0223) - rust-lang#109661 (Fix LVI test post LLVM 16 update) - rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`) - rust-lang#109669 (Update books) - rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`) - rust-lang#109682 (Add `#[inline]` to CStr trait implementations) - rust-lang#109685 (Make doc comment a little bit more accurate) - rust-lang#109687 (Document the heuristics IsTerminal uses on Windows) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes#100060
Note that there is still a warning - the
unused_allocationlint does not fire in stage 0, but that's just a matter of waiting for #104363 to land in beta