Skip to content

Add #[inline] to CStr trait implementations - #109682

Merged
bors merged 1 commit into
rust-lang:masterfrom
clubby789:c-str-inline
Mar 28, 2023
Merged

Add #[inline] to CStr trait implementations#109682
bors merged 1 commit into
rust-lang:masterfrom
clubby789:c-str-inline

Conversation

@clubby789

@clubby789clubby789 commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Fixes#109674

I noticed other usages of traits on CStr weren't being inlined, so also added hints to the other implementations

@rustbot

rustbot commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2023
@rustbot

rustbot commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

scottmcm
scottmcm reviewed Mar 28, 2023
View reviewed changes
Comment threadlibrary/core/src/ffi/c_str.rs Outdated
@scottmcm

scottmcm commented Mar 28, 2023

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 901f108 has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
@scottmcmscottmcm assigned scottmcm and unassigned thomccMar 28, 2023
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2023
@bors
Auto merge ofrust-lang#109690- matthiaskrgr:rollup-6p5m0es, r=matth…
f418859
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#108548 (Clarify the 'use a constant in a pattern' error message)
- rust-lang#109565 (Improve documentation for E0223)
- rust-lang#109661 (Fix LVI test post LLVM 16 update)
- rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`)
- rust-lang#109669 (Update books)
- rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`)
- rust-lang#109682 (Add `#[inline]` to CStr trait implementations)
- rust-lang#109685 (Make doc comment a little bit more accurate)
- rust-lang#109687 (Document the heuristics IsTerminal uses on Windows)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 90b6c71 into rust-lang:masterMar 28, 2023
@rustbotrustbot added this to the 1.70.0 milestone Mar 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottmcmscottmcmscottmcm left review comments

Assignees

@scottmcmscottmcm

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

CStr eq acts as an optimization barrier

5 participants

@clubby789@rustbot@scottmcm@bors@thomcc