Skip to content

Make doc comment a little bit more accurate - #109685

Merged
bors merged 1 commit into
rust-lang:masterfrom
est31:not_llvm_but_backend
Mar 28, 2023
Merged

Make doc comment a little bit more accurate#109685
bors merged 1 commit into
rust-lang:masterfrom
est31:not_llvm_but_backend

Conversation

@est31

Copy link
Copy Markdown
Member

It queries not LLVM in particular but the codegen backend in general. While cranelift does not provide target features, other codegen backends do.

Found while looking for this answer.

It queries not LLVM in particular but the codegen backend *in general*.
While cranelift does not provide target features, other codegen backends do.
@rustbot

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2023
@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 7bbc8ef has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2023
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#108548 (Clarify the 'use a constant in a pattern' error message)
- rust-lang#109565 (Improve documentation for E0223)
- rust-lang#109661 (Fix LVI test post LLVM 16 update)
- rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`)
- rust-lang#109669 (Update books)
- rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`)
- rust-lang#109682 (Add `#[inline]` to CStr trait implementations)
- rust-lang#109685 (Make doc comment a little bit more accurate)
- rust-lang#109687 (Document the heuristics IsTerminal uses on Windows)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cad4893 into rust-lang:masterMar 28, 2023
@rustbotrustbot added this to the 1.70.0 milestone Mar 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@est31@rustbot@jyn514@bors@petrochenkov