Skip to content

warn if source is not either a git clone or a dist tarball - #116292

Merged
bors merged 1 commit into
rust-lang:masterfrom
onur-ozkan:warn-wrong-sources
Oct 1, 2023
Merged

warn if source is not either a git clone or a dist tarball#116292
bors merged 1 commit into
rust-lang:masterfrom
onur-ozkan:warn-wrong-sources

Conversation

@onur-ozkan

Copy link
Copy Markdown
Contributor

When the repository is downloaded directly via HTTP(as in #115041), builds may fail due to missing submodules.

This PR adds a check that warns people in such cases.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 30, 2023
@clubby789

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 88e7718 has been approved by clubby789

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2023
…iaskrgr
Rollup of 3 pull requests
Successful merges:
- rust-lang#116292 (warn if source is not either a git clone or a dist tarball)
- rust-lang#116295 (Fix `core::mem::drop` docs inaccuracy)
- rust-lang#116299 (Update location of `auxiliary/lint-plugin-test.rs`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cb4e299 into rust-lang:masterOct 1, 2023
@rustbotrustbot added this to the 1.75.0 milestone Oct 1, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2023
Rollup merge of rust-lang#116292 - onur-ozkan:warn-wrong-sources, r=clubby789
warn if source is not either a git clone or a dist tarball
When the repository is downloaded directly via HTTP(as in rust-lang#115041), builds may fail due to missing submodules.
This PR adds a check that warns people in such cases.
bors-ferroceneBot added a commit to ferrocene/ferrocene that referenced this pull request Oct 5, 2023
23: Fix divergence from upstream `master` r=tshepang a=pvdrz
* rust-lang/rust#116381
* rust-lang/rust#116360
* rust-lang/rust#116353
* rust-lang/rust#116406
* rust-lang/rust#116408
* rust-lang/rust#116395
* rust-lang/rust#116393
* rust-lang/rust#116388
* rust-lang/rust#116365
* rust-lang/rust#116363
* rust-lang/rust#116146
* rust-lang/rust#115961
* rust-lang/rust#116386
* rust-lang/rust#116367
* rust-lang/rust#105394
* rust-lang/rust#115301
* rust-lang/rust#116384
* rust-lang/rust#116379
* rust-lang/rust#116328
* rust-lang/rust#116282
* rust-lang/rust#116261
* rust-lang/rust#114654
* rust-lang/rust#116376
* rust-lang/rust#116374
* rust-lang/rust#116371
* rust-lang/rust#116358
* rust-lang/rust#116210
* rust-lang/rust#115863
* rust-lang/rust#115025
* rust-lang/rust#116372
* rust-lang/rust#116361
* rust-lang/rust#116355
* rust-lang/rust#116351
* rust-lang/rust#116158
* rust-lang/rust#115726
* rust-lang/rust#113053
* rust-lang/rust#116083
* rust-lang/rust#102099
* rust-lang/rust#116356
* rust-lang/rust#116350
* rust-lang/rust#116349
* rust-lang/rust#116289
* rust-lang/rust#114454
* rust-lang/rust#114453
* rust-lang/rust#116331
* rust-lang/rust#116346
* rust-lang/rust#116340
* rust-lang/rust#116326
* rust-lang/rust#116313
* rust-lang/rust#116276
* rust-lang/rust#115898
* rust-lang/rust#116325
* rust-lang/rust#116317
* rust-lang/rust#116207
* rust-lang/rust#116281
* rust-lang/rust#116304
* rust-lang/rust#116259
* rust-lang/rust#116228
* rust-lang/rust#116224
* rust-lang/rust#115554
* rust-lang/rust#116311
* rust-lang/rust#116299
* rust-lang/rust#116295
* rust-lang/rust#116292
* rust-lang/rust#116307
* rust-lang/rust#115670
* rust-lang/rust#116225
* rust-lang/rust#116302
* rust-lang/rust#116108
* rust-lang/rust#116160
* rust-lang/rust#116157
* rust-lang/rust#116127
* rust-lang/rust#116286
* rust-lang/rust#116254
* rust-lang/rust#116195
* rust-lang/rust#116280
* rust-lang/rust#115933
* rust-lang/rust#115546
* rust-lang/rust#115368
* rust-lang/rust#116275
* rust-lang/rust#116263
* rust-lang/rust#116241
* rust-lang/rust#116216
* rust-lang/rust#116030
* rust-lang/rust#116024
* rust-lang/rust#112123
* rust-lang/rust#113301
* rust-lang/rust#113797
* rust-lang/rust#115759
* rust-lang/rust#116260
* rust-lang/rust#116253
* rust-lang/rust#116245
* rust-lang/rust#116239
* rust-lang/rust#116234
* rust-lang/rust#116231
* rust-lang/rust#116201
* rust-lang/rust#116133
* rust-lang/rust#116176
* rust-lang/rust#116089
* rust-lang/rust#115986
Co-authored-by: ouz-a <ouz.agz@gmail.com>
Co-authored-by: Jakub Beránek <berykubik@gmail.com>
Co-authored-by: Federico Stra <stra.federico@gmail.com>
Co-authored-by: bohan <bohan-zhang@foxmail.com>
Co-authored-by: Jason Newcomb <jsnewcomb@pm.me>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Oli Scherer <git-spam-no-reply9815368754983@oli-obk.de>
bors-ferroceneBot added a commit to ferrocene/ferrocene that referenced this pull request Oct 6, 2023
23: Fix divergence from upstream `master` r=tshepang a=pvdrz
* rust-lang/rust#116483
* rust-lang/rust#116475
* rust-lang/rust#116329
* rust-lang/rust#116198
* rust-lang/rust#115588
* rust-lang/rust#115522
* rust-lang/rust#115454
* rust-lang/rust#111595
* rust-lang/rust#116018
* rust-lang/rust#116472
* rust-lang/rust#116469
* rust-lang/rust#116421
* rust-lang/rust#116463
* rust-lang/rust#101150
* rust-lang/rust#116269
* rust-lang/rust#116417
* rust-lang/rust#116455
* rust-lang/rust#116452
* rust-lang/rust#116428
* rust-lang/rust#116415
* rust-lang/rust#116288
* rust-lang/rust#116220
* rust-lang/rust#103046
* rust-lang/rust#114042
* rust-lang/rust#104153
* rust-lang/rust#116427
* rust-lang/rust#116443
* rust-lang/rust#116432
* rust-lang/rust#116431
* rust-lang/rust#116429
* rust-lang/rust#116296
* rust-lang/rust#116223
* rust-lang/rust#116273
* rust-lang/rust#116184
* rust-lang/rust#116370
* rust-lang/rust#114417
* rust-lang/rust#115200
* rust-lang/rust#116413
* rust-lang/rust#116381
* rust-lang/rust#116360
* rust-lang/rust#116353
* rust-lang/rust#116406
* rust-lang/rust#116408
* rust-lang/rust#116395
* rust-lang/rust#116393
* rust-lang/rust#116388
* rust-lang/rust#116365
* rust-lang/rust#116363
* rust-lang/rust#116146
* rust-lang/rust#115961
* rust-lang/rust#116386
* rust-lang/rust#116367
* rust-lang/rust#105394
* rust-lang/rust#115301
* rust-lang/rust#116384
* rust-lang/rust#116379
* rust-lang/rust#116328
* rust-lang/rust#116282
* rust-lang/rust#116261
* rust-lang/rust#114654
* rust-lang/rust#116376
* rust-lang/rust#116374
* rust-lang/rust#116371
* rust-lang/rust#116358
* rust-lang/rust#116210
* rust-lang/rust#115863
* rust-lang/rust#115025
* rust-lang/rust#116372
* rust-lang/rust#116361
* rust-lang/rust#116355
* rust-lang/rust#116351
* rust-lang/rust#116158
* rust-lang/rust#115726
* rust-lang/rust#113053
* rust-lang/rust#116083
* rust-lang/rust#102099
* rust-lang/rust#116356
* rust-lang/rust#116350
* rust-lang/rust#116349
* rust-lang/rust#116289
* rust-lang/rust#114454
* rust-lang/rust#114453
* rust-lang/rust#116331
* rust-lang/rust#116346
* rust-lang/rust#116340
* rust-lang/rust#116326
* rust-lang/rust#116313
* rust-lang/rust#116276
* rust-lang/rust#115898
* rust-lang/rust#116325
* rust-lang/rust#116317
* rust-lang/rust#116207
* rust-lang/rust#116281
* rust-lang/rust#116304
* rust-lang/rust#116259
* rust-lang/rust#116228
* rust-lang/rust#116224
* rust-lang/rust#115554
* rust-lang/rust#116311
* rust-lang/rust#116299
* rust-lang/rust#116295
* rust-lang/rust#116292
* rust-lang/rust#116307
* rust-lang/rust#115670
* rust-lang/rust#116225
* rust-lang/rust#116302
* rust-lang/rust#116108
* rust-lang/rust#116160
* rust-lang/rust#116157
* rust-lang/rust#116127
* rust-lang/rust#116286
* rust-lang/rust#116254
* rust-lang/rust#116195
* rust-lang/rust#116280
* rust-lang/rust#115933
* rust-lang/rust#115546
* rust-lang/rust#115368
* rust-lang/rust#116275
* rust-lang/rust#116263
* rust-lang/rust#116241
* rust-lang/rust#116216
* rust-lang/rust#116030
* rust-lang/rust#116024
* rust-lang/rust#112123
* rust-lang/rust#113301
* rust-lang/rust#113797
* rust-lang/rust#115759
* rust-lang/rust#116260
* rust-lang/rust#116253
* rust-lang/rust#116245
* rust-lang/rust#116239
* rust-lang/rust#116234
* rust-lang/rust#116231
* rust-lang/rust#116201
* rust-lang/rust#116133
* rust-lang/rust#116176
* rust-lang/rust#116089
* rust-lang/rust#115986
Co-authored-by: ouz-a <ouz.agz@gmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Co-authored-by: linkmauve <linkmauve@linkmauve.fr>
Co-authored-by: onur-ozkan <work@onurozkan.dev>
Co-authored-by: asquared31415 <34665709+asquared31415@users.noreply.github.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Nadrieril <nadrieril+git@gmail.com>
Co-authored-by: Raekye <Raekye@users.noreply.github.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
bors-ferroceneBot added a commit to ferrocene/ferrocene that referenced this pull request Oct 9, 2023
23: Fix divergence from upstream `master` r=pietroalbini a=pvdrz
* rust-lang/rust#116483
* rust-lang/rust#116475
* rust-lang/rust#116329
* rust-lang/rust#116198
* rust-lang/rust#115588
* rust-lang/rust#115522
* rust-lang/rust#115454
* rust-lang/rust#111595
* rust-lang/rust#116018
* rust-lang/rust#116472
* rust-lang/rust#116469
* rust-lang/rust#116421
* rust-lang/rust#116463
* rust-lang/rust#101150
* rust-lang/rust#116269
* rust-lang/rust#116417
* rust-lang/rust#116455
* rust-lang/rust#116452
* rust-lang/rust#116428
* rust-lang/rust#116415
* rust-lang/rust#116288
* rust-lang/rust#116220
* rust-lang/rust#103046
* rust-lang/rust#114042
* rust-lang/rust#104153
* rust-lang/rust#116427
* rust-lang/rust#116443
* rust-lang/rust#116432
* rust-lang/rust#116431
* rust-lang/rust#116429
* rust-lang/rust#116296
* rust-lang/rust#116223
* rust-lang/rust#116273
* rust-lang/rust#116184
* rust-lang/rust#116370
* rust-lang/rust#114417
* rust-lang/rust#115200
* rust-lang/rust#116413
* rust-lang/rust#116381
* rust-lang/rust#116360
* rust-lang/rust#116353
* rust-lang/rust#116406
* rust-lang/rust#116408
* rust-lang/rust#116395
* rust-lang/rust#116393
* rust-lang/rust#116388
* rust-lang/rust#116365
* rust-lang/rust#116363
* rust-lang/rust#116146
* rust-lang/rust#115961
* rust-lang/rust#116386
* rust-lang/rust#116367
* rust-lang/rust#105394
* rust-lang/rust#115301
* rust-lang/rust#116384
* rust-lang/rust#116379
* rust-lang/rust#116328
* rust-lang/rust#116282
* rust-lang/rust#116261
* rust-lang/rust#114654
* rust-lang/rust#116376
* rust-lang/rust#116374
* rust-lang/rust#116371
* rust-lang/rust#116358
* rust-lang/rust#116210
* rust-lang/rust#115863
* rust-lang/rust#115025
* rust-lang/rust#116372
* rust-lang/rust#116361
* rust-lang/rust#116355
* rust-lang/rust#116351
* rust-lang/rust#116158
* rust-lang/rust#115726
* rust-lang/rust#113053
* rust-lang/rust#116083
* rust-lang/rust#102099
* rust-lang/rust#116356
* rust-lang/rust#116350
* rust-lang/rust#116349
* rust-lang/rust#116289
* rust-lang/rust#114454
* rust-lang/rust#114453
* rust-lang/rust#116331
* rust-lang/rust#116346
* rust-lang/rust#116340
* rust-lang/rust#116326
* rust-lang/rust#116313
* rust-lang/rust#116276
* rust-lang/rust#115898
* rust-lang/rust#116325
* rust-lang/rust#116317
* rust-lang/rust#116207
* rust-lang/rust#116281
* rust-lang/rust#116304
* rust-lang/rust#116259
* rust-lang/rust#116228
* rust-lang/rust#116224
* rust-lang/rust#115554
* rust-lang/rust#116311
* rust-lang/rust#116299
* rust-lang/rust#116295
* rust-lang/rust#116292
* rust-lang/rust#116307
* rust-lang/rust#115670
* rust-lang/rust#116225
* rust-lang/rust#116302
* rust-lang/rust#116108
* rust-lang/rust#116160
* rust-lang/rust#116157
* rust-lang/rust#116127
* rust-lang/rust#116286
* rust-lang/rust#116254
* rust-lang/rust#116195
* rust-lang/rust#116280
* rust-lang/rust#115933
* rust-lang/rust#115546
* rust-lang/rust#115368
* rust-lang/rust#116275
* rust-lang/rust#116263
* rust-lang/rust#116241
* rust-lang/rust#116216
* rust-lang/rust#116030
* rust-lang/rust#116024
* rust-lang/rust#112123
* rust-lang/rust#113301
* rust-lang/rust#113797
* rust-lang/rust#115759
* rust-lang/rust#116260
* rust-lang/rust#116253
* rust-lang/rust#116245
* rust-lang/rust#116239
* rust-lang/rust#116234
* rust-lang/rust#116231
* rust-lang/rust#116201
* rust-lang/rust#116133
* rust-lang/rust#116176
* rust-lang/rust#116089
* rust-lang/rust#115986
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: ouz-a <ouz.agz@gmail.com>
Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Co-authored-by: linkmauve <linkmauve@linkmauve.fr>
Co-authored-by: onur-ozkan <work@onurozkan.dev>
Co-authored-by: asquared31415 <34665709+asquared31415@users.noreply.github.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Nadrieril <nadrieril+git@gmail.com>
Co-authored-by: Raekye <Raekye@users.noreply.github.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
bors-ferroceneBot added a commit to ferrocene/ferrocene that referenced this pull request Oct 9, 2023
23: Fix divergence from upstream `master` r=Dajamante a=pvdrz
* rust-lang/rust#116483
* rust-lang/rust#116475
* rust-lang/rust#116329
* rust-lang/rust#116198
* rust-lang/rust#115588
* rust-lang/rust#115522
* rust-lang/rust#115454
* rust-lang/rust#111595
* rust-lang/rust#116018
* rust-lang/rust#116472
* rust-lang/rust#116469
* rust-lang/rust#116421
* rust-lang/rust#116463
* rust-lang/rust#101150
* rust-lang/rust#116269
* rust-lang/rust#116417
* rust-lang/rust#116455
* rust-lang/rust#116452
* rust-lang/rust#116428
* rust-lang/rust#116415
* rust-lang/rust#116288
* rust-lang/rust#116220
* rust-lang/rust#103046
* rust-lang/rust#114042
* rust-lang/rust#104153
* rust-lang/rust#116427
* rust-lang/rust#116443
* rust-lang/rust#116432
* rust-lang/rust#116431
* rust-lang/rust#116429
* rust-lang/rust#116296
* rust-lang/rust#116223
* rust-lang/rust#116273
* rust-lang/rust#116184
* rust-lang/rust#116370
* rust-lang/rust#114417
* rust-lang/rust#115200
* rust-lang/rust#116413
* rust-lang/rust#116381
* rust-lang/rust#116360
* rust-lang/rust#116353
* rust-lang/rust#116406
* rust-lang/rust#116408
* rust-lang/rust#116395
* rust-lang/rust#116393
* rust-lang/rust#116388
* rust-lang/rust#116365
* rust-lang/rust#116363
* rust-lang/rust#116146
* rust-lang/rust#115961
* rust-lang/rust#116386
* rust-lang/rust#116367
* rust-lang/rust#105394
* rust-lang/rust#115301
* rust-lang/rust#116384
* rust-lang/rust#116379
* rust-lang/rust#116328
* rust-lang/rust#116282
* rust-lang/rust#116261
* rust-lang/rust#114654
* rust-lang/rust#116376
* rust-lang/rust#116374
* rust-lang/rust#116371
* rust-lang/rust#116358
* rust-lang/rust#116210
* rust-lang/rust#115863
* rust-lang/rust#115025
* rust-lang/rust#116372
* rust-lang/rust#116361
* rust-lang/rust#116355
* rust-lang/rust#116351
* rust-lang/rust#116158
* rust-lang/rust#115726
* rust-lang/rust#113053
* rust-lang/rust#116083
* rust-lang/rust#102099
* rust-lang/rust#116356
* rust-lang/rust#116350
* rust-lang/rust#116349
* rust-lang/rust#116289
* rust-lang/rust#114454
* rust-lang/rust#114453
* rust-lang/rust#116331
* rust-lang/rust#116346
* rust-lang/rust#116340
* rust-lang/rust#116326
* rust-lang/rust#116313
* rust-lang/rust#116276
* rust-lang/rust#115898
* rust-lang/rust#116325
* rust-lang/rust#116317
* rust-lang/rust#116207
* rust-lang/rust#116281
* rust-lang/rust#116304
* rust-lang/rust#116259
* rust-lang/rust#116228
* rust-lang/rust#116224
* rust-lang/rust#115554
* rust-lang/rust#116311
* rust-lang/rust#116299
* rust-lang/rust#116295
* rust-lang/rust#116292
* rust-lang/rust#116307
* rust-lang/rust#115670
* rust-lang/rust#116225
* rust-lang/rust#116302
* rust-lang/rust#116108
* rust-lang/rust#116160
* rust-lang/rust#116157
* rust-lang/rust#116127
* rust-lang/rust#116286
* rust-lang/rust#116254
* rust-lang/rust#116195
* rust-lang/rust#116280
* rust-lang/rust#115933
* rust-lang/rust#115546
* rust-lang/rust#115368
* rust-lang/rust#116275
* rust-lang/rust#116263
* rust-lang/rust#116241
* rust-lang/rust#116216
* rust-lang/rust#116030
* rust-lang/rust#116024
* rust-lang/rust#112123
* rust-lang/rust#113301
* rust-lang/rust#113797
* rust-lang/rust#115759
* rust-lang/rust#116260
* rust-lang/rust#116253
* rust-lang/rust#116245
* rust-lang/rust#116239
* rust-lang/rust#116234
* rust-lang/rust#116231
* rust-lang/rust#116201
* rust-lang/rust#116133
* rust-lang/rust#116176
* rust-lang/rust#116089
* rust-lang/rust#115986
35: Automated pull from `rust-lang/libc` r=pietroalbini a=github-actions[bot]
This PR pulls the following changes from the [`rust-lang/libc`](https://github.com/rust-lang/libc) repository:
* rust-lang/libc#3335
* rust-lang/libc#3373
* rust-lang/libc#3360
* rust-lang/libc#3374
* rust-lang/libc#3375
* rust-lang/libc#3376
* rust-lang/libc#3377
Co-authored-by: ouz-a <ouz.agz@gmail.com>
Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: linkmauve <linkmauve@linkmauve.fr>
Co-authored-by: onur-ozkan <work@onurozkan.dev>
Co-authored-by: asquared31415 <34665709+asquared31415@users.noreply.github.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Nadrieril <nadrieril+git@gmail.com>
Co-authored-by: Raekye <Raekye@users.noreply.github.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
Co-authored-by: Nikolay Arhipov <nikolajs.arhipovs@gmail.com>
Co-authored-by: Brian Cain <bcain@quicinc.com>
Co-authored-by: Steve Lau <stevelauc@outlook.com>
Co-authored-by: David CARLIER <devnexen@gmail.com>
Co-authored-by: Louis Dupré Bertoni <louisdb@lespetitspedestres.org>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@onur-ozkan@rustbot@clubby789@bors