Emit feature gate *warning* for `auto` traits pre-expansion by compiler-errors · Pull Request #116393 · rust-lang/rust

compiler-errors · 2023-10-03T19:13:08Z

Auto traits were introduced before we were more careful about not stabilizing new syntax pre-expansion.

This is a more conservative step in the general direction we want to go in https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Removal.20of.20.60auto.20trait.60.20syntax.

Fixes#116121

rustbot · 2023-10-03T19:13:16Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-10-03T19:14:31Z

@rust-lang/lang came to the consensus in the triage meeting today that this is a compiler concern and not a lang concern, and we're free to start emitting this warning for auto trait syntax pre-expansion.

Lang will have more discussions about what to do with auto traits in general.

WaffleLapkin · 2023-10-03T19:25:08Z

r? WaffleLapkin
r=me with CI green

compiler-errors · 2023-10-03T19:48:09Z

@bors r=WaffleLapkin

bors · 2023-10-03T19:48:11Z

📌 Commit 7815641 has been approved by WaffleLapkin

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#115961 (Replace 'mutex' with 'lock' in RwLock documentation) - rust-lang#116146 (Clarify `arg` and `args` documentation) - rust-lang#116363 (Adapt `todo!` documentation to mention displaying custom values) - rust-lang#116365 (bootstrap: make copying linker binaries conditional) - rust-lang#116388 (rustdoc: fix & clean up handling of cross-crate higher-ranked parameters) - rust-lang#116393 (Emit feature gate *warning* for `auto` traits pre-expansion) - rust-lang#116395 (Mark myself as vacation or whatever) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116393 - compiler-errors:auto-bad, r=WaffleLapkin Emit feature gate *warning* for `auto` traits pre-expansion Auto traits were introduced before we were more careful about not stabilizing new syntax pre-expansion. This is a more conservative step in the general direction we want to go in https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Removal.20of.20.60auto.20trait.60.20syntax. Fixesrust-lang#116121

Emit pre-expansion feature gate warnings for negative impls and specialization Follow up to rust-lang#154475; part of rust-lang#154045. This shouldn't need any extra input from T-compiler or T-lang since it's legitimized by [MCP 535](rust-lang/compiler-team#535). However, I have a feeling that negative impls & specialization behind "`#[cfg(feature = "nightly")]`" are more prevalent in the ecosystem compared to e.g., auto traits & box patterns, so these new warnings will probably hit a bunch of users. In any case, it's only a warning for now not an error so e.g., running crater "in deny mode" or nominating for a T-lang meeting discussion would be disproportionate (esp. since T-lang [has confirmed in the past](rust-lang#116393 (comment)) that this is a T-compiler matter).

Rollup merge of #154527 - fmease:more-soft-gates, r=nnethercote Emit pre-expansion feature gate warnings for negative impls and specialization Follow up to #154475; part of #154045. This shouldn't need any extra input from T-compiler or T-lang since it's legitimized by [MCP 535](rust-lang/compiler-team#535). However, I have a feeling that negative impls & specialization behind "`#[cfg(feature = "nightly")]`" are more prevalent in the ecosystem compared to e.g., auto traits & box patterns, so these new warnings will probably hit a bunch of users. In any case, it's only a warning for now not an error so e.g., running crater "in deny mode" or nominating for a T-lang meeting discussion would be disproportionate (esp. since T-lang [has confirmed in the past](#116393 (comment)) that this is a T-compiler matter).

Emit pre-expansion feature gate warnings for negative impls and specialization Follow up to rust-lang/rust#154475; part of rust-lang/rust#154045. This shouldn't need any extra input from T-compiler or T-lang since it's legitimized by [MCP 535](rust-lang/compiler-team#535). However, I have a feeling that negative impls & specialization behind "`#[cfg(feature = "nightly")]`" are more prevalent in the ecosystem compared to e.g., auto traits & box patterns, so these new warnings will probably hit a bunch of users. In any case, it's only a warning for now not an error so e.g., running crater "in deny mode" or nominating for a T-lang meeting discussion would be disproportionate (esp. since T-lang [has confirmed in the past](rust-lang/rust#116393 (comment)) that this is a T-compiler matter).

Gate against auto traits pre-expansion
7815641

rustbot assigned wesleywiser Oct 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2023

fmease approved these changes Oct 3, 2023
View reviewed changes

WaffleLapkin approved these changes Oct 3, 2023
View reviewed changes

rustbot assigned WaffleLapkin and unassigned wesleywiser Oct 3, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

matthiaskrgr mentioned this pull request Oct 4, 2023
Rollup of 7 pull requests #116408
Merged

bors merged commit 4ed2291 into rust-lang:masterOct 4, 2023

rustbot added this to the 1.75.0 milestone Oct 4, 2023

pvdrz mentioned this pull request Oct 4, 2023
Fix divergence from upstream masterferrocene/ferrocene#23
Merged

This was referenced Mar 28, 2026
Tracking issue for migrating all remaining post-expansion feature gates to pre-expansion ones #154045
Open
Emit pre-expansion feature gate warnings for negative impls and specialization #154527
Merged

Navigation Menu

Uh oh!

Uh oh!

Emit feature gate warning for `auto` traits pre-expansion - #116393

Emit feature gate warning for `auto` traits pre-expansion#116393
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:auto-bad

compiler-errors commented Oct 3, 2023•
edited
Loading

Uh oh!

rustbot commented Oct 3, 2023

Uh oh!

compiler-errors commented Oct 3, 2023•
edited
Loading

Uh oh!

WaffleLapkin commented Oct 3, 2023

Uh oh!

compiler-errors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

compiler-errors commented Oct 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 3, 2023

Uh oh!

compiler-errors commented Oct 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WaffleLapkin commented Oct 3, 2023

Uh oh!

compiler-errors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

compiler-errors commented Oct 3, 2023•
edited
Loading

compiler-errors commented Oct 3, 2023•
edited
Loading