Rollup of 5 pull requests by matthiaskrgr · Pull Request #116384 · rust-lang/rust

matthiaskrgr · 2023-10-03T14:24:18Z

Successful merges:

Suggest pin!() instead of Pin::new() when appropriate #114654 (Suggest pin!() instead of Pin::new() when appropriate)
a small wf and clause cleanup #116261 (a small wf and clause cleanup)
Fix broken links #116282 (Fix broken links)
Factor out common token generation in fluent_messages. #116328 (Factor out common token generation in fluent_messages.)
non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound #116379 (non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound)

r? @ghost
@rustbot modify labels: rollup

When encountering a type that needs to be pinned but that is `!Unpin`, suggest using the `pin!()` macro. Fixrust-lang#57994.

Signed-off-by: cui fliter <imcusg@gmail.com>

The failure and success cases are similar enough that they can share code.

Compiling any part of the compiler will almost certainly require Nightly.

…dtwco Suggest `pin!()` instead of `Pin::new()` when appropriate When encountering a type that needs to be pinned but that is `!Unpin`, suggest using the `pin!()` macro. Fixrust-lang#57994.

a small wf and clause cleanup - remove `Clause::from_projection_clause`, instead use `ToPredicate` - change `predicate_obligations` to directly take a `Clause` - remove some unnecessary `&` - use clause in `min_specialization` checks where easily applicable

Fix broken links The previous address is no longer available, replace it with the latest available one.

…davidtwco Factor out common token generation in `fluent_messages`. The failure and success cases are similar enough that they can share code. r? `@davidtwco`

…drs, r=compiler-errors non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound Opaque types like `impl for<T> Trait<T>` would previously lead to an ICE. r? `@compiler-errors`

matthiaskrgr · 2023-10-03T14:24:36Z

@bors r+ rollup=never p=5

bors · 2023-10-03T14:24:38Z

📌 Commit 9143370 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-10-03T16:15:39Z

⌛ Testing commit 9143370 with merge 268d625...

bors · 2023-10-03T18:34:01Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 268d625 to master...

rust-timer · 2023-10-03T18:35:29Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#114654	Suggest `pin!()` instead of `Pin::new()` when appropriate	`d4867d7bc37061a23bdc732c56e48169c578184a` (link)
#116261	a small wf and clause cleanup	`ad09210864f9ed27f2caad9888dcf1bd88084d0f` (link)
#116282	Fix broken links	`9c9fab70295b6beeb5b4de7fd4bc9ab1752ed8cd` (link)
#116328	Factor out common token generation in `fluent_messages`.	`d1457f935af44f361a3a0142706a0451b1714829` (link)
#116379	non_lifetime_binders: fix ICE in lint opaque-hidden-inferre…	`f74dcff86b548cc18a1b3ca4976c122884b9b79d` (link)

previous master: e3c631b3de

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-10-03T19:55:28Z

Finished benchmarking commit (268d625): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.8%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 1.2%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.8%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 620.955s -> 622.003s (0.17%)
Artifact size: 271.99 MiB -> 272.02 MiB (0.01%)

Mark-Simulacrum · 2023-10-10T13:16:24Z

Regressions look to be spurious/noise, marking as triaged.

estebankand others added 13 commits August 14, 2023 19:41

Suggest pin!() instead of Pin::new() when appropriate
2c3fd1a
When encountering a type that needs to be pinned but that is `!Unpin`, suggest using the `pin!()` macro. Fixrust-lang#57994.

rebase and review comments
6b58fbf

a small wf and clause cleanup
a4f6770

specialization: use clause
aac29a0

Fix broken links
6ef3fd7
Signed-off-by: cui fliter <imcusg@gmail.com>

Factor out common token generation in fluent_messages.
5f4177a
The failure and success cases are similar enough that they can share code.

Fix a comment.
57397de
Compiling any part of the compiler will almost certainly require Nightly.

non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound
3f0a327

Rollup merge ofrust-lang#114654- estebank:suggest-pin-macro, r=davi…
535cd8d
…dtwco Suggest `pin!()` instead of `Pin::new()` when appropriate When encountering a type that needs to be pinned but that is `!Unpin`, suggest using the `pin!()` macro. Fixrust-lang#57994.

Rollup merge ofrust-lang#116282- rustaceanclub:master, r=davidtwco
a4ba529
Fix broken links The previous address is no longer available, replace it with the latest available one.

Rollup merge ofrust-lang#116328- nnethercote:rustc_fluent_macro, r=…
5dd9313
…davidtwco Factor out common token generation in `fluent_messages`. The failure and success cases are similar enough that they can share code. r? `@davidtwco`

Rollup merge ofrust-lang#116379- fmease:opaq-hid-inf-bnds-non-lt-bn…
9143370
…drs, r=compiler-errors non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound Opaque types like `impl for<T> Trait<T>` would previously lead to an ICE. r? `@compiler-errors`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 3, 2023

bors merged commit 268d625 into rust-lang:masterOct 3, 2023

rustbot added this to the 1.75.0 milestone Oct 3, 2023

This was referenced Oct 3, 2023
WIP: Check uninhabitedness through the trait solver #116247
Draft
split NormalizesTo out of Projection 2 #116262
Closed

rustbot added the perf-regression Performance regression. label Oct 3, 2023

pvdrz mentioned this pull request Oct 4, 2023
Fix divergence from upstream masterferrocene/ferrocene#23
Merged

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Oct 10, 2023

matthiaskrgr deleted the rollup-se332zs branch March 16, 2024 18:19

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #116384

Rollup of 5 pull requests#116384
bors merged 13 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-se332zs

matthiaskrgr commented Oct 3, 2023

Uh oh!

matthiaskrgr commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

rust-timer commented Oct 3, 2023

Uh oh!

rust-timer commented Oct 3, 2023

Uh oh!

Mark-Simulacrum commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Oct 3, 2023

Uh oh!

matthiaskrgr commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

rust-timer commented Oct 3, 2023

Uh oh!

rust-timer commented Oct 3, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants