Use GitHub Actions M1 builder for aarch64-apple-darwin by shepmaster · Pull Request #116368 · rust-lang/rust

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.3%, -0.6%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.4%, 2.7%]	2
Regressions ❌ (secondary)	2.8%	[0.9%, 6.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	2.5%	[2.4%, 2.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.606s -> 630.852s (-0.12%)
Artifact size: 301.98 MiB -> 303.98 MiB (0.66%)

Kobzol · 2023-10-23T08:42:34Z

CI time of dist-aarch64-apple after the update:

Kobzol · 2023-10-23T08:54:11Z

- --disable-docs
 --set rust.jemalloc
 --set llvm.ninja=false
+ --set rust.lto=thin


Hmm, I'm not sure we should have sneaked LTO in here with the change to M1 builders. Hopefully it won't cause any issues, but next time I'd prefer to do it in a separate PR.

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 3, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2023
Auto merge ofrust-lang#116368- shepmaster:github-actions-m1, r=<try>
4ea6801
Use GitHub Actions M1 builder for aarch64-apple-darwin r? `@ghost`

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2023
Auto merge ofrust-lang#116368- shepmaster:github-actions-m1, r=<try>
3c126b6
Use GitHub Actions M1 builder for aarch64-apple-darwin r? `@ghost`

shepmaster added 2 commits October 9, 2023 19:02

Install awscli on the aarch64-apple-darwin builder
2bf3004
Unlike the other builders, this one doesn't come with it preinstalled.

Use GitHub Actions M1 builder for aarch64-apple-darwin
821b03d
Additionally, this enables 1. building the documentation 2. Setting `rust.lto` to `thin` to match the x86_64 build

shepmaster force-pushed the github-actions-m1 branch from b33f89c to 5cc5281Compare October 10, 2023 00:47

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2023
Auto merge ofrust-lang#116368- shepmaster:github-actions-m1, r=<try>
3bc2f72
Use GitHub Actions M1 builder for aarch64-apple-darwin r? `@ghost`

shepmaster added O-macos Operating system: macOS A-github-actions Area: GitHub Actions (GHA) O-AArch64 Armv8-A or later processors in AArch64 mode and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Oct 10, 2023

shepmaster force-pushed the github-actions-m1 branch from 5cc5281 to 821b03dCompare October 10, 2023 02:03

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 10, 2023

rustbot assigned emilyalbini Oct 10, 2023

Mark-Simulacrum self-assigned this Oct 16, 2023

Mark-Simulacrum unassigned emilyalbini Oct 16, 2023

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2023

bors merged commit 8581200 into rust-lang:masterOct 21, 2023

rustbot added this to the 1.75.0 milestone Oct 21, 2023

bors mentioned this pull request Oct 21, 2023
[WIP] CI: use BuildKit Docker layer caching #114762
Closed

shepmaster deleted the github-actions-m1 branch October 21, 2023 22:23

Kobzol reviewed Oct 23, 2023
View reviewed changes

github-actionsBot mentioned this pull request Oct 31, 2023
Automated pull from upstream masterferrocene/ferrocene#74
Merged

Uh oh!

Uh oh!

Conversation

shepmaster commented Oct 3, 2023

Uh oh!

shepmaster commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 3, 2023

Uh oh!

shepmaster commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

shepmaster commented Oct 10, 2023

Uh oh!

bors commented Oct 10, 2023

Uh oh!

bors commented Oct 10, 2023

Uh oh!

shepmaster commented Oct 10, 2023

Uh oh!

Mark-Simulacrum commented Oct 21, 2023

Uh oh!

bors commented Oct 21, 2023

Uh oh!

bors commented Oct 21, 2023

Uh oh!

bors commented Oct 21, 2023

Uh oh!

rust-timer commented Oct 22, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Oct 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KobzolOct 23, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Kobzol commented Oct 23, 2023•
edited
Loading