Detect object safety errors when assoc type is missing by estebank · Pull Request #116405 · rust-lang/rust

estebank · 2023-10-04T01:11:00Z

When an associated type with GATs isn't specified in a dyn Trait, emit an object safety error instead of only complaining about the missing associated type, as it will lead the user down a path of three different errors before letting them know that what they were trying to do is impossible to begin with.

Fix#103155.

rustbot · 2023-10-04T01:11:08Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

davidtwco

Apologies for how long it has taken me to get to this. Is there a test for the object safety error being emitted from this PR? I couldn't see one but might have missed it.

estebank · 2023-10-18T21:38:03Z

@davidtwco ha, I thought I'd added a test for it. Added now.

davidtwco · 2023-10-27T13:58:52Z

@bors r+

bors · 2023-10-27T13:58:54Z

📌 Commit cd54ada has been approved by davidtwco

It is now in the queue for this repository.

bors · 2023-10-28T07:01:42Z

⌛ Testing commit cd54ada with merge 371d420...

Detect object safety errors when assoc type is missing When an associated type with GATs isn't specified in a `dyn Trait`, emit an object safety error instead of only complaining about the missing associated type, as it will lead the user down a path of three different errors before letting them know that what they were trying to do is impossible to begin with. Fixrust-lang#103155.

bors · 2023-10-28T07:40:46Z

💔 Test failed - checks-actions

When an associated type with GATs isn't specified in a `dyn Trait`, emit an object safety error instead of only complaining about the missing associated type, as it will lead the user down a path of three different errors before letting them know that what they were trying to do is impossible to begin with. Fixrust-lang#103155.

estebank · 2023-10-30T22:19:39Z

@bors r=davidtwco

bors · 2023-10-30T22:19:42Z

📌 Commit b8a8ba9 has been approved by davidtwco

It is now in the queue for this repository.

bors · 2023-10-30T22:47:51Z

⌛ Testing commit b8a8ba9 with merge a395214...

bors · 2023-10-31T00:47:00Z

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing a395214 to master...

rust-timer · 2023-10-31T04:50:52Z

Finished benchmarking commit (a395214): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-5.1%, -5.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.607s -> 636.057s (-0.09%)
Artifact size: 304.46 MiB -> 304.45 MiB (-0.01%)

rustbot assigned davidtwco Oct 4, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2023

davidtwco reviewed Oct 18, 2023
View reviewed changes

estebank force-pushed the issue-103155 branch from 0fa4c17 to 517ca59Compare October 18, 2023 21:37

This comment was marked as resolved.
Sign in to view

estebank force-pushed the issue-103155 branch from 517ca59 to cd54adaCompare October 26, 2023 20:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2023

estebank added 3 commits October 30, 2023 22:12

Add test
8c55772

Sort errors
b8a8ba9

estebank force-pushed the issue-103155 branch from cd54ada to b8a8ba9Compare October 30, 2023 22:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2023

bors merged commit a395214 into rust-lang:masterOct 31, 2023

rustbot added this to the 1.75.0 milestone Oct 31, 2023

github-actionsBot mentioned this pull request Oct 31, 2023
Automated pull from upstream masterferrocene/ferrocene#74
Merged

estebank deleted the issue-103155 branch November 9, 2023 05:12

Uh oh!

Uh oh!

Conversation

estebank commented Oct 4, 2023

Uh oh!

rustbot commented Oct 4, 2023

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

estebank commented Oct 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

davidtwco commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 28, 2023

Uh oh!

estebank commented Oct 30, 2023

Uh oh!

bors commented Oct 30, 2023

Uh oh!

bors commented Oct 30, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

rust-timer commented Oct 31, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebank commented Oct 18, 2023•
edited
Loading