Add support for global allocation in smir by celinval · Pull Request #118012 · rust-lang/rust

celinval · 2023-11-17T16:45:40Z

Add APIs to StableMir to support global allocation. Before this change, StableMir users had no API available to retrieve Allocation provenance information. They had to resource to internal APIs instead.

One example is retrieving the Allocation of an &str. See test for an example on how the API can be used.

rustbot · 2023-11-17T16:45:49Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-17T16:45:52Z

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

rustbot · 2023-11-17T18:21:34Z

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

petrochenkov · 2023-11-17T21:04:32Z

r? @petrochenkov

Why me of all people, I never even touched stable MIR!
r? compiler

petrochenkov · 2023-11-17T21:05:31Z

Reroll.
r? compiler

celinval · 2023-11-17T21:06:13Z

r? @petrochenkov
Why me of all people, I never even touched stable MIR! r? compiler

Sorry @petrochenkov, that was automatic assignment. I've created a PR to automatically assign stable mir PRs to one of the project members.

celinval · 2023-11-17T21:07:54Z

r? @spastorino

bors · 2023-11-18T01:57:39Z

☔ The latest upstream changes (presumably #118023) made this pull request unmergeable. Please resolve the merge conflicts.

ouz-a · 2023-11-18T08:40:22Z

could you please explain the current necessity for supporting this feature, and the contexts in which it will be utilized

compiler-errors · 2023-11-20T17:48:11Z

Yeah, I agree with @ouz-a and think this PR should be more motivated. Maybe fill out the PR description a bit more?

celinval · 2023-11-20T23:03:26Z

@compiler-errors @ouz-a, I added a basic test and edited the PR's description. Let me know if that makes more sense. Thanks

bors · 2023-11-21T07:25:25Z

☔ The latest upstream changes (presumably #118015) made this pull request unmergeable. Please resolve the merge conflicts.

ouz-a · 2023-11-21T16:45:38Z

@bors r+ rollup

bors · 2023-11-21T16:45:41Z

📌 Commit 0e32d56 has been approved by ouz-a

It is now in the queue for this repository.

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118109 (rustdoc-search: simplify `checkPath` and `sortResults`) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup

celinval · 2023-11-22T03:23:04Z

@bors r=@ouz-a

bors · 2023-11-22T03:23:07Z

📌 Commit c07a6d5 has been approved by ouz-a

It is now in the queue for this repository.

…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#118012 (Add support for global allocation in smir) - rust-lang#118013 (Enable Rust to use the EHCont security feature of Windows) - rust-lang#118100 (Enable profiler in dist-powerpc64-linux) - rust-lang#118142 (Tighten up link attributes for llvm-wrapper bindings) - rust-lang#118147 (Fix some unnecessary casts) - rust-lang#118161 (Allow defining opaques in `check_coroutine_obligations`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118012 - celinval:smir-alloc, r=ouz-a Add support for global allocation in smir Add APIs to StableMir to support global allocation. Before this change, StableMir users had no API available to retrieve Allocation provenance information. They had to resource to internal APIs instead. One example is retrieving the Allocation of an `&str`. See test for an example on how the API can be used.

rustbot assigned petrochenkov Nov 17, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2023

This comment has been minimized.
Sign in to view

celinval force-pushed the smir-alloc branch from cd559ad to 2b8d5ddCompare November 17, 2023 18:21

rustbot assigned b-naber and unassigned petrochenkov Nov 17, 2023

rustbot assigned TaKO8Ki and unassigned b-naber Nov 17, 2023

rustbot assigned spastorino and unassigned TaKO8Ki Nov 17, 2023

ouz-a reviewed Nov 20, 2023
View reviewed changes

Comment threadcompiler/rustc_smir/src/rustc_smir/mod.rs

compiler-errors assigned compiler-errors and ouz-a and unassigned spastorino Nov 20, 2023

celinval force-pushed the smir-alloc branch from 2b8d5dd to b3eb30fCompare November 20, 2023 20:11

ouz-a approved these changes Nov 21, 2023
View reviewed changes

celinval force-pushed the smir-alloc branch from b3eb30f to 0e32d56Compare November 21, 2023 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2023

matthiaskrgr mentioned this pull request Nov 21, 2023
Rollup of 4 pull requests #118141
Closed

This was referenced Nov 21, 2023
Rollup of 6 pull requests #118151
Closed
Rollup of 5 pull requests #118152
Merged

celinval added 3 commits November 21, 2023 19:16

Add support to global allocation to stable-mir
fa5ff85

Add support to get virtual table allocation
5b3cf66

Add allocation test and a bit more documentation
c07a6d5

celinval force-pushed the smir-alloc branch from 0e32d56 to c07a6d5Compare November 22, 2023 03:20

compiler-errors mentioned this pull request Nov 22, 2023
Rollup of 6 pull requests #118178
Merged

bors merged commit d58ded9 into rust-lang:masterNov 22, 2023

rustbot added this to the 1.76.0 milestone Nov 22, 2023

celinval mentioned this pull request Nov 23, 2023
Handle Prov better rust-lang/rustc_public#22
Closed

Uh oh!

Uh oh!

Conversation

celinval commented Nov 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 17, 2023

Uh oh!

rustbot commented Nov 17, 2023

Uh oh!

This comment has been minimized.

rustbot commented Nov 17, 2023

Uh oh!

petrochenkov commented Nov 17, 2023

Uh oh!

petrochenkov commented Nov 17, 2023

Uh oh!

celinval commented Nov 17, 2023

Uh oh!

celinval commented Nov 17, 2023

Uh oh!

bors commented Nov 18, 2023

Uh oh!

ouz-a commented Nov 18, 2023

Uh oh!

Uh oh!

compiler-errors commented Nov 20, 2023

Uh oh!

celinval commented Nov 20, 2023

Uh oh!

bors commented Nov 21, 2023

Uh oh!

ouz-a commented Nov 21, 2023

Uh oh!

bors commented Nov 21, 2023

Uh oh!

celinval commented Nov 22, 2023

Uh oh!

bors commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

celinval commented Nov 17, 2023•
edited
Loading