Uh oh!
There was an error while loading. Please reload this page.
Fix some unnecessary casts - #118147
Merged
Merged
Conversation
rustbot
commented
Nov 21, 2023
Collaborator
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
Noratrieb
requested review from
WaffleLapkin
and removed request for
WaffleLapkinNovember 21, 2023 20:47
This comment has been minimized.
This comment has been minimized.
`x clippy compiler -Aclippy::all -Wclippy::unnecessary_cast --fix` with some manual review to ensure every fix is correct.
Noratriebforce-pushed
the
no-redundant-casts
branch
from
November 21, 2023 21:11
c9df3cb to
c089a16CompareMember
iirc there were problems on different architectures with these :/ |
WaffleLapkin
approved these changes
Nov 21, 2023
WaffleLapkin
commented
Nov 21, 2023
Member
@matthiaskrgr do you have a reference? I don't really see how any of those can cause problems on diff. arches... |
matthiaskrgr
commented
Nov 21, 2023
Member
It's probably buried in some year-old pr, I could not find anything right now. May also be that the code has already changed in the meantime or clippy got better somehow , CI will make the final call I guess.. |
Member
Okay, well, r=me with green CI then |
Noratrieb
commented
Nov 21, 2023
MemberAuthor
Correct, some "redundant" casts are necessary. I checked the source and dest types manually in the source and only included the actually redundant casts here. |
Noratrieb
commented
Nov 21, 2023
MemberAuthor
CI is partially green, good enough for me 😈 |
bors
commented
Nov 21, 2023
Collaborator
matthiaskrgr
commented
Nov 21, 2023
Member
I was not referring to the pre-merge ci 😅 |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 21, 2023
…ffleLapkin Fix some unnecessary casts `x clippy compiler -Aclippy::all -Wclippy::unnecessary_cast --fix` with some manual review to ensure every fix is correct.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#118012 (Add support for global allocation in smir) - rust-lang#118013 (Enable Rust to use the EHCont security feature of Windows) - rust-lang#118100 (Enable profiler in dist-powerpc64-linux) - rust-lang#118142 (Tighten up link attributes for llvm-wrapper bindings) - rust-lang#118147 (Fix some unnecessary casts) - rust-lang#118161 (Allow defining opaques in `check_coroutine_obligations`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
Rollup merge of rust-lang#118147 - Nilstrieb:no-redundant-casts, r=WaffleLapkin Fix some unnecessary casts `x clippy compiler -Aclippy::all -Wclippy::unnecessary_cast --fix` with some manual review to ensure every fix is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x clippy compiler -Aclippy::all -Wclippy::unnecessary_cast --fixwith some manual review to ensure every fix is correct.