Uh oh!
There was an error while loading. Please reload this page.
Tighten up link attributes for llvm-wrapper bindings - #118142
Merged
Merged
Conversation
tmiasko
commented
Nov 21, 2023
Contributor
@bors r+ |
bors
commented
Nov 21, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#118012 (Add support for global allocation in smir) - rust-lang#118013 (Enable Rust to use the EHCont security feature of Windows) - rust-lang#118100 (Enable profiler in dist-powerpc64-linux) - rust-lang#118142 (Tighten up link attributes for llvm-wrapper bindings) - rust-lang#118147 (Fix some unnecessary casts) - rust-lang#118161 (Allow defining opaques in `check_coroutine_obligations`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
Rollup merge of rust-lang#118142 - saethlin:llvm-linkage, r=tmiasko Tighten up link attributes for llvm-wrapper bindings Fixesrust-lang#118084 by moving all of the declarations of symbols from `llvm_rust` into a separate extern block with `#[link(name = "llvm-wrapper", kind = "static")]`. This also renames `LLVMTimeTraceProfiler*` to `LLVMRustTimeTraceProfiler*` because those are functions from `llvm_rust`. r? tmiasko
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 1, 2025
Add link attribute for Enzyme's LLVMRust FFI Since rust-lang#133429 landed, the compiler doesn't build with `-Zcross-crate-inline-threshold=always`. I don't expect anyone else to test or fix issues with that goofy configuration, so I'm fixing it. This PR adds a link attribute just like rust-lang#118142 for all the new LLVMRust functions. They were actually added in rust-lang#130060 but weren't used until just now.
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2025
Rollup merge of rust-lang#136374 - saethlin:enzyme-linkage, r=oli-obk Add link attribute for Enzyme's LLVMRust FFI Since rust-lang#133429 landed, the compiler doesn't build with `-Zcross-crate-inline-threshold=always`. I don't expect anyone else to test or fix issues with that goofy configuration, so I'm fixing it. This PR adds a link attribute just like rust-lang#118142 for all the new LLVMRust functions. They were actually added in rust-lang#130060 but weren't used until just now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#118084 by moving all of the declarations of symbols from
llvm_rustinto a separate extern block with#[link(name = "llvm-wrapper", kind = "static")].This also renames
LLVMTimeTraceProfiler*toLLVMRustTimeTraceProfiler*because those are functions fromllvm_rust.r? tmiasko