Skip to content

compiletest: Add exact-llvm-major-version directive - #132995

Merged
bors merged 2 commits into
rust-lang:masterfrom
Eclips4:issue-132348
Nov 14, 2024
Merged

compiletest: Add exact-llvm-major-version directive#132995
bors merged 2 commits into
rust-lang:masterfrom
Eclips4:issue-132348

Conversation

@Eclips4

@Eclips4Eclips4 commented Nov 13, 2024•
edited by jieyouxu
Loading

Copy link
Copy Markdown
Contributor

Now contributors don't need to use min-llvm-version: X + ignore-llvm-version: X+1 - 99, so they can simply use exact-llvm-major-version: X

To be honest, I didn't find any usages of that hack other than the one mentioned in the issue. ( tests/codegen/try_question_mark_nop.rs)
Closes#132348.

rustc-dev-guide PR for //@ exact-llvm-major-version: rust-lang/rustc-dev-guide#2135

r? jieyouxu

@rustbot

rustbot commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

Could not assign reviewer from: jieyouxu.
User(s) jieyouxu are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot

rustbot commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 13, 2024
@rustbot

rustbot commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@jieyouxu

jieyouxu commented Nov 13, 2024

Copy link
Copy Markdown
Member

r? jieyouxu

jieyouxu
jieyouxu approved these changes Nov 13, 2024
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few suggestions but LGTM otherwise.

Comment threadsrc/tools/compiletest/src/header.rs Outdated
Comment threadsrc/tools/compiletest/src/header.rs Outdated
Comment threadsrc/tools/compiletest/src/header.rs Outdated
Comment threadsrc/tools/compiletest/src/header/tests.rs
@jieyouxu

jieyouxu commented Nov 13, 2024

Copy link
Copy Markdown
Member

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@Eclips4

Eclips4 commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2024
@jieyouxujieyouxu mentioned this pull request Nov 13, 2024
Merged
jieyouxu
jieyouxu approved these changes Nov 13, 2024
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll r+ when PR CI is green.

@jieyouxu

jieyouxu commented Nov 13, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 81f6105 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@jieyouxujieyouxu mentioned this pull request Nov 13, 2024
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge ofrust-lang#133006- matthiaskrgr:rollup-dz6oiq5, r=matth…
bd0826a
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#126046 (Implement `mixed_integer_ops_unsigned_sub`)
- rust-lang#132302 (rustdoc: Treat declarative macros more like other item kinds)
- rust-lang#132842 (ABI checks: add support for tier2 arches)
- rust-lang#132995 (compiletest: Add ``exact-llvm-major-version`` directive)
- rust-lang#132996 (Trim extra space when suggesting removing bad `let`)
- rust-lang#132998 (Unvacation myself)
- rust-lang#133000 ([rustdoc] Fix duplicated footnote IDs)
- rust-lang#133001 (actually test next solver)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a1923b3 into rust-lang:masterNov 14, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@rust-timer
Unrolled build forrust-lang#132995
5031780
Rollup merge of rust-lang#132995 - Eclips4:issue-132348, r=jieyouxu
compiletest: Add ``exact-llvm-major-version`` directive
Now contributors don't need to use `min-llvm-version: X` + `ignore-llvm-version: X+1 - 99`, so they can simply use `exact-llvm-major-version: X`
To be honest, I didn't find any usages of that hack other than the one mentioned in the issue. ( `tests/codegen/try_question_mark_nop.rs`)
Closesrust-lang#132348.
rustc-dev-guide PR for `//@ exact-llvm-major-version`: rust-lang/rustc-dev-guide#2135
r? jieyouxu
@Eclips4
Eclips4 deleted the issue-132348 branch November 14, 2024 09:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

compiletest: allow only running a test if we have a *specific* llvm major version

5 participants

@Eclips4@rustbot@jieyouxu@bors@compiler-errors